Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Unified Diff: tools/gn/functions_target.cc

Issue 1386783003: [GN]: Support for loadable modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: mark comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/functions_target.cc
diff --git a/tools/gn/functions_target.cc b/tools/gn/functions_target.cc
index ffe8f5f2941ebfc4bb8d978b244d65a9d71118f5..88cb9f80e30b2e55725e964b7d08fa26b6d59da1 100644
--- a/tools/gn/functions_target.cc
+++ b/tools/gn/functions_target.cc
@@ -19,7 +19,8 @@
" Deps: data_deps, deps, forward_dependent_configs_from, public_deps\n"
#define GENERAL_TARGET_VARS \
" General: check_includes, configs, data, inputs, output_name,\n" \
- " output_extension, public, sources, testonly, visibility\n"
+ " output_extension, public, sources, testonly, visibility,\n" \
+ " loadable_module, darwin_bundle\n"
namespace functions {
@@ -503,8 +504,7 @@ Value RunTarget(Scope* scope,
BlockNode* block,
Err* err) {
if (args.size() != 2) {
- *err = Err(function, "Expected two arguments.",
- "Dude, try \"gn help target\".");
+ *err = Err(function, "Expected two arguments. Try \"gn help target\".");
return Value();
}

Powered by Google App Engine
This is Rietveld 408576698