Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Unified Diff: tools/gn/runtime_deps.cc

Issue 1386783003: [GN]: Support for loadable modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/gn/runtime_deps.cc
diff --git a/tools/gn/runtime_deps.cc b/tools/gn/runtime_deps.cc
index f6441e8cd113b4ddd9ac96ec12e40904a782ba36..d82831199fdca5f31529ad73e7d29b955b65e5a3 100644
--- a/tools/gn/runtime_deps.cc
+++ b/tools/gn/runtime_deps.cc
@@ -81,8 +81,10 @@ void RecursiveCollectRuntimeDeps(const Target* target,
}
(*seen_targets)[target] = is_target_data_dep;
- // Add the main output file for executables and shared libraries.
+ // Add the main output file for executables, shared libraries, and
+ // loadable modules.
if (target->output_type() == Target::EXECUTABLE ||
+ target->output_type() == Target::LOADABLE_MODULE ||
target->output_type() == Target::SHARED_LIBRARY)
AddIfNew(GetMainOutput(target), target, deps, found_files);
@@ -149,8 +151,8 @@ const char kRuntimeDeps_Help[] =
"\n"
" To a first approximation, the runtime dependencies of a target are\n"
" the set of \"data\" files, data directories, and the shared libraries\n"
- " from all transitive dependencies. Executables and shared libraries are\n"
- " considered runtime dependencies of themselves.\n"
+ " from all transitive dependencies. Executables, shared libraries, and\n"
+ " loadable modules are considered runtime dependencies of themselves.\n"
"\n"
"Executables\n"
"\n"

Powered by Google App Engine
This is Rietveld 408576698