tools/gn/ninja_toolchain_writer.cc - Issue 1386783003: [GN]: Support for loadable modules

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/ninja_toolchain_writer.cc

Issue 1386783003: [GN]: Support for loadable modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: unit tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/gn/ninja_toolchain_writer.cc

diff --git a/tools/gn/ninja_toolchain_writer.cc b/tools/gn/ninja_toolchain_writer.cc

index c22fb2c43527d04cd92d2d71138df06441941be3..1c2cd1c0dd685101619260aa65024dd01dfe61f0 100644

--- a/tools/gn/ninja_toolchain_writer.cc

+++ b/tools/gn/ninja_toolchain_writer.cc

@@ -109,8 +109,11 @@ void NinjaToolchainWriter::WriteToolRule(const Toolchain::ToolType type,

// The link pool applies to linker tools. Don't count TYPE_ALINK since

// static libraries are not generally intensive to write.

- if (type == Toolchain::TYPE_SOLINK || type == Toolchain::TYPE_LINK)

+ if (type == Toolchain::TYPE_SOLINK

+ || type == Toolchain::TYPE_SOLINK_MODULE

brettw 2015/10/13 23:13:33 || goes at end-of-line

Bons 2015/10/13 23:30:52 Done.

+ || type == Toolchain::TYPE_LINK) {

out_ << kIndent << "pool = link_pool\n";

+ }

if (tool->restat())

out_ << kIndent << "restat = 1" << std::endl;