Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(736)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/gn/commands.cc

Issue 1386783003: [GN]: Support for loadable modules (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit tests Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« tools/gn/binary_target_generator.cc ('K') | « tools/gn/commands.h ('k') | tools/gn/docs/faq.md » ('j') | tools/gn/docs/language.md » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/commands.cc
diff --git a/tools/gn/commands.cc b/tools/gn/commands.cc
index ab22ebe43c8851b799c8d899404c199567781442..3778d5bb6445574e563e4f6788e3280b4b99bda1 100644
--- a/tools/gn/commands.cc
+++ b/tools/gn/commands.cc
@@ -190,6 +190,10 @@ bool GetTargetTypeFilter(Target::OutputType* type) {
*type = Target::SHARED_LIBRARY;
return true;
}
+ if (value == "loadable_module") {
+ *type = Target::LOADABLE_MODULE;
+ return true;
+ }
if (value == "static_library") {
*type = Target::STATIC_LIBRARY;
return true;
« tools/gn/binary_target_generator.cc ('K') | « tools/gn/commands.h ('k') | tools/gn/docs/faq.md » ('j') | tools/gn/docs/language.md » ('J')

Powered by Google App Engine
This is Rietveld 408576698