[GN]: Support for loadable modules

tools/gn/binary_target_generator.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "tools/gn/binary_target_generator.h"
 
 #include "tools/gn/config_values_generator.h"
 #include "tools/gn/deps_iterator.h"
 #include "tools/gn/err.h"
 #include "tools/gn/functions.h"
@@ skipping 37 matching lines @@
 
   if (!FillConfigs())
     return;
 
   if (!FillAllowCircularIncludesFrom())
     return;
 
   if (!FillCompleteStaticLib())
     return;
 
+  if (!FillDarwinBundle())
+    return;
+
   // Config values (compiler flags, etc.) set directly on this target.
   ConfigValuesGenerator gen(&target_->config_values(), scope_,
                             scope_->GetSourceDir(), err_);
   gen.Run();
   if (err_->has_error())
     return;
 }
 
 bool BinaryTargetGenerator::FillCompleteStaticLib() {
   if (target_->output_type() == Target::STATIC_LIBRARY) {
@@ skipping 56 matching lines @@
           "deps.");
       return false;
     }
   }
 
   // Add to the set.
   for (const auto& cur : circular)
     target_->allow_circular_includes_from().insert(cur);
   return true;
 }
+
+bool BinaryTargetGenerator::FillDarwinBundle() {
+  // This flag only applies to executable, shared_library, and loadable_module
+  // target types.
+  if (target_->output_type() == Target::STATIC_LIBRARY)

[brettw, 2015/10/13 22:59:07]

This code should also be run for source sets. I think it would be better to
filter in the conditions we want to read this variable for rather than exclude
the other ones (i.e. check for executable, etc).

[Bons, 2015/10/13 23:12:47]

removed so non-issue.

+    return true;
+
+  const Value* value = scope_->GetValue(variables::kDarwinBundle, true);
+  if (value) {
+    if (!value->VerifyTypeIs(Value::BOOLEAN, err_))
+      return false;
+    target_->set_darwin_bundle(value->boolean_value());
+  }
+  return true;
+}