Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: third_party/WebKit/Source/core/css/CSSProperties.in

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Patch for landing Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/CSSProperties.in
diff --git a/third_party/WebKit/Source/core/css/CSSProperties.in b/third_party/WebKit/Source/core/css/CSSProperties.in
index dd9a465ebe7663256e45ac43da84acb16e33359c..7bee0746533ee41fc2849d9857e1dd04786dad34 100644
--- a/third_party/WebKit/Source/core/css/CSSProperties.in
+++ b/third_party/WebKit/Source/core/css/CSSProperties.in
@@ -14,6 +14,11 @@
// This doesn't currently work with alias_for.
+// - descriptor_only
+// These are actually descriptors and not CSS properties. Properties with
+// the same name as a descriptor do not get this flag.
+
+
// - longhands=property;other-property
// The property is a shorthand for several other properties.
@@ -443,17 +448,20 @@ z-index interpolable, type_name=int, custom_all
// TODO(timloh): This seems wrong, most of these shouldn't reach the StyleBuilder
all builder_skip
-font-display builder_skip, runtime_flag=CSSFontDisplay
-max-zoom builder_skip
-min-zoom builder_skip
-orientation builder_skip
page builder_skip
-src builder_skip
-unicode-range builder_skip
-user-zoom builder_skip
-webkit-font-size-delta builder_skip
-webkit-text-decorations-in-effect inherited, builder_skip
+// Descriptors
+
+font-display descriptor_only, runtime_flag=CSSFontDisplay
+max-zoom descriptor_only
+min-zoom descriptor_only
+orientation descriptor_only
+src descriptor_only
+unicode-range descriptor_only
+user-zoom descriptor_only
+
// Shorthands
animation longhands=animation-name;animation-duration;animation-timing-function;animation-delay;animation-iteration-count;animation-direction;animation-fill-mode;animation-play-state

Powered by Google App Engine
This is Rietveld 408576698