third_party/WebKit/Source/build/scripts/make_style_builder.py - Issue 1386733003: Do not accept CSS-wide keywords for descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/make_style_builder.py

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/make_style_builder.py

diff --git a/third_party/WebKit/Source/build/scripts/make_style_builder.py b/third_party/WebKit/Source/build/scripts/make_style_builder.py

index 1e81ac22acf7db0d2b39a5a5f17cc5d9548695c5..c5d5ca546fc202edd8a63c419f2ee7153b0b3ba1 100755

--- a/third_party/WebKit/Source/build/scripts/make_style_builder.py

+++ b/third_party/WebKit/Source/build/scripts/make_style_builder.py

@@ -65,7 +65,8 @@ class StyleBuilderWriter(css_properties.CSSProperties):

property['custom_inherit'] = True

property['custom_value'] = True

property['should_declare_functions'] = not property['use_handlers_for'] and not property['longhands'] \

- and not property['direction_aware'] and not property['builder_skip']

+ and not property['direction_aware'] and not property['builder_skip'] \

+ and not property['descriptor_only']

@template_expander.use_jinja('StyleBuilderFunctions.h.tmpl',

filters=filters)