third_party/WebKit/Source/build/scripts/css_properties.py - Issue 1386733003: Do not accept CSS-wide keywords for descriptors

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/css_properties.py

Issue 1386733003: Do not accept CSS-wide keywords for descriptors (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Patch for landing Created 4 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/build/scripts/css_properties.py

diff --git a/third_party/WebKit/Source/build/scripts/css_properties.py b/third_party/WebKit/Source/build/scripts/css_properties.py

index 50f4f38c1306299ec53f58c3671c9e0cbc6098f3..d4b7977bc3a0136beb8d8e02fc92492ceacd65e8 100755

--- a/third_party/WebKit/Source/build/scripts/css_properties.py

+++ b/third_party/WebKit/Source/build/scripts/css_properties.py

@@ -10,6 +10,7 @@ import name_utilities

class CSSProperties(in_generator.Writer):

defaults = {

'alias_for': None,

+ 'descriptor_only': None,

'runtime_flag': None,

'longhands': '',

'interpolable': False,

@@ -53,6 +54,7 @@ class CSSProperties(in_generator.Writer):

in_generator.Writer.__init__(self, file_paths)

properties = self.in_file.name_dictionaries

+ self._descriptors = [property for property in properties if property['descriptor_only']]

self._aliases = [property for property in properties if property['alias_for']]

properties = [property for property in properties if not property['alias_for']]