Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Issue 138673002: Rename _untrusted targets in third_party to use _nacl suffix (Closed)

Created:
6 years, 11 months ago by Sergey Ulanov
Modified:
6 years, 11 months ago
Reviewers:
brettw, David Tseng
CC:
chromium-reviews
Visibility:
Public.

Description

Rename _untrusted targets in third_party to use _nacl suffix Previously NaCl targets were using _untrusted suffix which makes the purpose of these targets hard to understand. This CL renames some targets in src/third_party. Also removed toolsets field from modp_b64_nacl.gyp Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245176

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -312 lines) Patch
M chrome/chrome_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download
M chrome/third_party/chromevox/chromevox.gyp View 1 chunk +1 line, -1 line 0 comments Download
A + third_party/jsoncpp/jsoncpp_nacl.gyp View 1 chunk +2 lines, -2 lines 0 comments Download
D third_party/jsoncpp/jsoncpp_untrusted.gyp View 1 chunk +0 lines, -34 lines 0 comments Download
A + third_party/liblouis/liblouis_nacl.gyp View 5 chunks +8 lines, -8 lines 0 comments Download
D third_party/liblouis/liblouis_untrusted.gyp View 1 chunk +0 lines, -186 lines 0 comments Download
A + third_party/modp_b64/modp_b64_nacl.gyp View 2 chunks +2 lines, -3 lines 1 comment Download
D third_party/modp_b64/modp_b64_untrusted.gyp View 1 chunk +0 lines, -30 lines 0 comments Download
A + third_party/opus/opus_nacl.gyp View 2 chunks +3 lines, -3 lines 0 comments Download
D third_party/opus/opus_untrusted.gyp View 1 chunk +0 lines, -44 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Sergey Ulanov
https://codereview.chromium.org/138673002/diff/1/third_party/modp_b64/modp_b64_nacl.gyp File third_party/modp_b64/modp_b64_nacl.gyp (left): https://codereview.chromium.org/138673002/diff/1/third_party/modp_b64/modp_b64_nacl.gyp#oldcode22 third_party/modp_b64/modp_b64_nacl.gyp:22: 'toolsets': ['host', 'target'], This is not related to rename. ...
6 years, 11 months ago (2014-01-14 18:53:39 UTC) #1
brettw
lgtm
6 years, 11 months ago (2014-01-14 19:00:55 UTC) #2
David Tseng
lgtm
6 years, 11 months ago (2014-01-15 20:24:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/138673002/1
6 years, 11 months ago (2014-01-15 21:31:46 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 06:43:41 UTC) #5
Message was sent while issue was closed.
Change committed as 245176

Powered by Google App Engine
This is Rietveld 408576698