Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1386723002: Remove some images that are no longer needed on views (Closed)

Created:
5 years, 2 months ago by Evan Stade
Modified:
5 years, 2 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, asanka, toyoshim+midi_chromium.org, mlamouri+watch-geolocation_chromium.org, feature-media-reviews_chromium.org, benjhayden+dwatch_chromium.org, vabr+watchlist_chromium.org, mcasas+watch_chromium.org, raymes+watch_chromium.org, posciak+watch_chromium.org, oshima+watch_chromium.org, Michael van Ouwerkerk, mlamouri+watch-permissions_chromium.org, peter+watch_chromium.org, mlamouri+watch-notifications_chromium.org, markusheintz_, xhwang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove some images that are no longer needed on views BUG=536129 Committed: https://crrev.com/526d041cb098d1b00609a496f7591534bf706158 Cr-Commit-Position: refs/heads/master@{#352457}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Messages

Total messages: 15 (5 generated)
Evan Stade
oshima: themes sky: permission_bubble_request_impl.cc
5 years, 2 months ago (2015-10-02 19:57:06 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386723002/20001
5 years, 2 months ago (2015-10-02 20:08:06 UTC) #5
oshima
lgtm
5 years, 2 months ago (2015-10-02 20:11:48 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-02 20:53:16 UTC) #8
sky
https://codereview.chromium.org/1386723002/diff/20001/chrome/browser/permissions/permission_bubble_request_impl.cc File chrome/browser/permissions/permission_bubble_request_impl.cc (left): https://codereview.chromium.org/1386723002/diff/20001/chrome/browser/permissions/permission_bubble_request_impl.cc#oldcode78 chrome/browser/permissions/permission_bubble_request_impl.cc:78: #if defined(OS_CHROMEOS) How come it's safe to remove this?
5 years, 2 months ago (2015-10-02 23:26:40 UTC) #9
Evan Stade
https://codereview.chromium.org/1386723002/diff/20001/chrome/browser/permissions/permission_bubble_request_impl.cc File chrome/browser/permissions/permission_bubble_request_impl.cc (left): https://codereview.chromium.org/1386723002/diff/20001/chrome/browser/permissions/permission_bubble_request_impl.cc#oldcode78 chrome/browser/permissions/permission_bubble_request_impl.cc:78: #if defined(OS_CHROMEOS) On 2015/10/02 23:26:39, sky wrote: > How ...
5 years, 2 months ago (2015-10-05 18:42:52 UTC) #10
sky
LGTM
5 years, 2 months ago (2015-10-05 21:44:50 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386723002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386723002/20001
5 years, 2 months ago (2015-10-05 21:49:30 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-05 23:01:47 UTC) #14
commit-bot: I haz the power
5 years, 2 months ago (2015-10-05 23:03:31 UTC) #15
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/526d041cb098d1b00609a496f7591534bf706158
Cr-Commit-Position: refs/heads/master@{#352457}

Powered by Google App Engine
This is Rietveld 408576698