Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2103)

Unified Diff: chrome/browser/resources/bookmark_manager/js/main.js

Issue 13867005: Recent and Search in Bookmark manager don't allow Open operations. (Closed) Base URL: https://src.chromium.org/chrome/trunk/src/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/bookmark_manager/js/main.js
===================================================================
--- chrome/browser/resources/bookmark_manager/js/main.js (revision 194106)
+++ chrome/browser/resources/bookmark_manager/js/main.js (working copy)
@@ -314,10 +314,13 @@
* @return {!Array.<!BookmarkTreeNode>} .
*/
function getBookmarkNodesForOpenCommands(target) {
- if (target == tree)
- return tree.selectedFolders;
- var listItems = list.selectedItems;
- return listItems.length ? listItems : list.dataModel.slice();
+ if (target == tree) {
+ var folderItem = tree.selectedItem;
+ return (folderItem == recentTreeItem || folderItem == searchTreeItem) ?
+ list.dataModel.slice() : tree.selectedFolders;
+ }
+ var items = list.selectedItems;
+ return items.length == 0 ? list.dataModel.slice() : items;
yosin_UTC9 2013/04/15 01:28:26 nit: return items.length ? items : list.dataModel.
Tom Cassiotis 2013/04/15 01:40:33 Done.
}
/**
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698