Recent and Search in Bookmark manager don't allow Open operations.

Recent and Search in Bookmark manager don't allow Open operations.

In the Bookmark manager the "Open..." context menu for the Recent and Search
'folder' items will apply to all the bookmarks in the bookmark list.

BUG=180158
TEST=Confirm context menu for folder item, multiple selected bookmarks and empty bookmark list are enabled and the "Open..." launch the correct bookmarks.
R=yosin@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195282

[Tom Cassiotis, 2013-04-14 02:36:35]

Yosi please take a look.

[yosin_UTC9, 2013-04-15 01:28:26]

LGTM
Eric, please take a look.
Thanks in advance.

https://codereview.chromium.org/13867005/diff/1/chrome/browser/resources/book...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/13867005/diff/1/chrome/browser/resources/book...
chrome/browser/resources/bookmark_manager/js/main.js:323: return items.length ==
0 ? list.dataModel.slice() : items;
nit: return items.length ? items : list.dataModel.slice();

[Tom Cassiotis, 2013-04-15 01:40:33]

https://codereview.chromium.org/13867005/diff/1/chrome/browser/resources/book...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/13867005/diff/1/chrome/browser/resources/book...
chrome/browser/resources/bookmark_manager/js/main.js:323: return items.length ==
0 ? list.dataModel.slice() : items;
On 2013/04/15 01:28:26, Yoshifumi Inoue wrote:
> nit: return items.length ? items : list.dataModel.slice();

Done.

[arv (Not doing code reviews), 2013-04-15 20:45:40]

LGTM

https://codereview.chromium.org/13867005/diff/5001/chrome/browser/resources/b...
File chrome/browser/resources/bookmark_manager/js/main.js (right):

https://codereview.chromium.org/13867005/diff/5001/chrome/browser/resources/b...
chrome/browser/resources/bookmark_manager/js/main.js:319: return (folderItem ==
recentTreeItem || folderItem == searchTreeItem) ?
Useless parens

[commit-bot: I haz the power, 2013-04-19 19:06:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/tom.cassiotis@gmail.com/13867005/9001

[commit-bot: I haz the power, 2013-04-19 21:07:58]

Change committed as 195282