Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: test/lib/TestGyp.py

Issue 13867004: Integrate ninja build with Visual Studio (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: with review comments Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | test/msvs/external_builder/external.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/lib/TestGyp.py
diff --git a/test/lib/TestGyp.py b/test/lib/TestGyp.py
index 6fb9d7a6edc341c824e076e9973c4ab739ab3b2f..c766bd460eb00fa6c6fac009153f7473a5f4eed0 100644
--- a/test/lib/TestGyp.py
+++ b/test/lib/TestGyp.py
@@ -785,13 +785,15 @@ class TestGypMSVS(TestGypOnMSToolchain):
super(TestGypMSVS, self).initialize_build_tool()
self.build_tool = self.devenv_path
- def build(self, gyp_file, target=None, rebuild=False, **kw):
+ def build(self, gyp_file, target=None, rebuild=False, clean=False, **kw):
"""
Runs a Visual Studio build using the configuration generated
from the specified gyp_file.
"""
configuration = self.configuration_buildname()
- if rebuild:
+ if clean:
+ build = '/Clean'
+ elif rebuild:
build = '/Rebuild'
else:
build = '/Build'
« no previous file with comments | « pylib/gyp/generator/msvs.py ('k') | test/msvs/external_builder/external.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698