Issue 1386683002: Revert of Incrementally flush GrDrawTarget

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1386683002: Revert of Incrementally flush GrDrawTarget (Closed)

Created:
5 years, 2 months ago by joshualitt

Modified:
5 years, 2 months ago

Reviewers:
bsalomon, robertphillips, joshua.litt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert of Incrementally flush GrDrawTarget (patchset #8 id:130001 of https://codereview.chromium.org/1386463004/ ) Reason for revert: breaking bots Original issue's description: > Incrementally flush GrDrawTarget > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/a7e878064509ef96b54d5507dab0b50def66dc13 TBR=robertphillips@google.com,bsalomon@google.com,joshualitt@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/0737f61f23ff9f0f50e982cfa260e1d10c9d6232

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -19 lines)			Patch
	M	src/gpu/GrDrawTarget.h	View		3 chunks	+1 line, -4 lines	0 comments	Download
	M	src/gpu/GrDrawTarget.cpp	View		3 chunks	+12 lines, -15 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1386683002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1386683002/1

5 years, 2 months ago (2015-10-02 17:15:58 UTC) #2

commit-bot: I haz the power

5 years, 2 months ago (2015-10-02 17:16:08 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/0737f61f23ff9f0f50e982cfa260e1d10c9d6232

Expand Messages | Collapse Messages