Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(167)

Issue 13866050: drive: Introduce DriveSystemServiceObserver (Closed)

Created:
7 years, 8 months ago by satorux1
Modified:
7 years, 8 months ago
Reviewers:
kinaba
CC:
chromium-reviews, nkostylev+watch_chromium.org, tfarina, Aaron Boodman, rginda+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

drive: Introduce DriveSystemServiceObserver Move DriveFileSystem::NotifyFileSystemMounted() and NotifyFileSystemToBeUnmounted() to DriveSystemServiceObserver in favor of less things to have in DriveFileSystem BUG=231788 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194529

Patch Set 1 : #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -59 lines) Patch
M chrome/browser/chromeos/drive/drive_file_system.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system.cc View 1 1 chunk +0 lines, -18 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_interface.h View 1 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_file_system_observer.h View 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_system_service.h View 4 chunks +23 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/drive/drive_system_service.cc View 1 2 chunks +14 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_drive_file_system.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/drive/fake_drive_file_system.cc View 1 1 chunk +0 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/mock_drive_file_system.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/drive_test_util.cc View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.h View 3 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/file_manager_event_router.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
7 years, 8 months ago (2013-04-16 06:49:14 UTC) #1
satorux1
ping
7 years, 8 months ago (2013-04-17 00:36:54 UTC) #2
kinaba
lgtm. sorry I missed the review request.
7 years, 8 months ago (2013-04-17 00:41:28 UTC) #3
satorux1
7 years, 8 months ago (2013-04-17 03:59:46 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r194529 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698