Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(474)

Unified Diff: webkit/media/webmediaplayer_impl.h

Issue 13866046: Change original WebMediaPlayer signatures from float to double. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webkit/media/android/webmediaplayer_impl_android.cc ('k') | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/webmediaplayer_impl.h
diff --git a/webkit/media/webmediaplayer_impl.h b/webkit/media/webmediaplayer_impl.h
index 591272e188a823933ed4f2e44f0a2aad4233abbe..f733e6fe3ae76ed0336345fa1a0807089024d53d 100644
--- a/webkit/media/webmediaplayer_impl.h
+++ b/webkit/media/webmediaplayer_impl.h
@@ -96,19 +96,19 @@ class WebMediaPlayerImpl
virtual bool supportsFullscreen() const;
virtual bool supportsSave() const;
virtual void seekFloat(float seconds);
- virtual void seek(float seconds);
+ virtual void seek(double seconds);
virtual void setEndTimeFloat(float seconds);
- virtual void setEndTime(float seconds);
+ virtual void setEndTime(double seconds);
virtual void setRateFloat(float rate);
- virtual void setRate(float rate);
+ virtual void setRate(double rate);
virtual void setVolumeFloat(float volume);
- virtual void setVolume(float volume);
+ virtual void setVolume(double volume);
virtual void setVisible(bool visible);
virtual void setPreload(WebKit::WebMediaPlayer::Preload preload);
virtual bool totalBytesKnown();
virtual const WebKit::WebTimeRanges& buffered();
virtual float maxTimeSeekableFloat() const;
- virtual float maxTimeSeekable() const;
+ virtual double maxTimeSeekable() const;
// Methods for painting.
virtual void setSize(const WebKit::WebSize& size);
@@ -128,9 +128,9 @@ class WebMediaPlayerImpl
virtual bool paused() const;
virtual bool seeking() const;
virtual float durationFloat() const;
- virtual float duration() const;
+ virtual double duration() const;
virtual float currentTimeFloat() const;
- virtual float currentTime() const;
+ virtual double currentTime() const;
// Get rate of loading the resource.
virtual int32 dataRate() const;
@@ -149,7 +149,7 @@ class WebMediaPlayerImpl
virtual WebKit::WebMediaPlayer::MovieLoadType movieLoadType() const;
virtual float mediaTimeForTimeValueFloat(float timeValue) const;
- virtual float mediaTimeForTimeValue(float timeValue) const;
+ virtual double mediaTimeForTimeValue(double timeValue) const;
virtual unsigned decodedFrameCount() const;
virtual unsigned droppedFrameCount() const;
@@ -307,13 +307,13 @@ class WebMediaPlayerImpl
// SetPlaybackRate(0) is being executed.
bool paused_;
bool seeking_;
- float playback_rate_;
+ double playback_rate_;
base::TimeDelta paused_time_;
// Seek gets pending if another seek is in progress. Only last pending seek
// will have effect.
bool pending_seek_;
- float pending_seek_seconds_;
+ double pending_seek_seconds_;
WebKit::WebMediaPlayerClient* client_;
« no previous file with comments | « webkit/media/android/webmediaplayer_impl_android.cc ('k') | webkit/media/webmediaplayer_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698