Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Unified Diff: webkit/media/android/webmediaplayer_android.h

Issue 13866046: Change original WebMediaPlayer signatures from float to double. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Address CR comments. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | webkit/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webkit/media/android/webmediaplayer_android.h
diff --git a/webkit/media/android/webmediaplayer_android.h b/webkit/media/android/webmediaplayer_android.h
index 79fa6b856611d5c2d45464e16f2fa6d15f094304..371513c9f45a932d2a45c0a5e06f218a022d4647 100644
--- a/webkit/media/android/webmediaplayer_android.h
+++ b/webkit/media/android/webmediaplayer_android.h
@@ -44,20 +44,20 @@ class WebMediaPlayerAndroid
virtual void play();
virtual void pause();
virtual void seekFloat(float seconds);
- virtual void seek(float seconds);
+ virtual void seek(double seconds);
virtual bool supportsFullscreen() const;
virtual bool supportsSave() const;
virtual void setEndTimeFloat(float seconds);
- virtual void setEndTime(float seconds);
+ virtual void setEndTime(double seconds);
virtual void setRateFloat(float rate);
- virtual void setRate(float rate);
+ virtual void setRate(double rate);
virtual void setVolumeFloat(float volume);
- virtual void setVolume(float volume);
+ virtual void setVolume(double volume);
virtual void setVisible(bool visible);
virtual bool totalBytesKnown();
virtual const WebKit::WebTimeRanges& buffered();
virtual float maxTimeSeekableFloat() const;
- virtual float maxTimeSeekable() const;
+ virtual double maxTimeSeekable() const;
// Methods for painting.
virtual void setSize(const WebKit::WebSize& size);
@@ -76,9 +76,9 @@ class WebMediaPlayerAndroid
virtual bool paused() const;
virtual bool seeking() const;
virtual float durationFloat() const;
- virtual float duration() const;
+ virtual double duration() const;
virtual float currentTimeFloat() const;
- virtual float currentTime() const;
+ virtual double currentTime() const;
// Get rate of loading the resource.
virtual int32 dataRate() const;
@@ -95,7 +95,7 @@ class WebMediaPlayerAndroid
virtual WebKit::WebMediaPlayer::MovieLoadType movieLoadType() const;
virtual float mediaTimeForTimeValueFloat(float timeValue) const;
- virtual float mediaTimeForTimeValue(float timeValue) const;
+ virtual double mediaTimeForTimeValue(double timeValue) const;
// Provide statistics.
virtual unsigned decodedFrameCount() const;
@@ -176,7 +176,7 @@ class WebMediaPlayerAndroid
virtual void SeekInternal(base::TimeDelta time) = 0;
// Get the current time from the media player.
- virtual float GetCurrentTimeInternal() const = 0;
+ virtual double GetCurrentTimeInternal() const = 0;
// Release the Android Media player.
virtual void ReleaseResourcesInternal() = 0;
@@ -217,7 +217,7 @@ class WebMediaPlayerAndroid
base::TimeDelta duration_;
// The time android media player is trying to seek.
- float pending_seek_;
+ double pending_seek_;
// Internal seek state.
bool seeking_;
« no previous file with comments | « no previous file | webkit/media/android/webmediaplayer_android.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698