Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Unified Diff: webkit/media/webmediaplayer_util.cc

Issue 13866046: Change original WebMediaPlayer signatures from float to double. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webkit/media/webmediaplayer_util.cc
diff --git a/webkit/media/webmediaplayer_util.cc b/webkit/media/webmediaplayer_util.cc
index e2d5ef8d62dcb5d2f275c3ed09c6584d56b5b11f..5f86682095c8303df2a5f73482ce239f49003a1d 100644
--- a/webkit/media/webmediaplayer_util.cc
+++ b/webkit/media/webmediaplayer_util.cc
@@ -8,15 +8,15 @@
namespace webkit_media {
-base::TimeDelta ConvertSecondsToTimestamp(float seconds) {
- float microseconds = seconds * base::Time::kMicrosecondsPerSecond;
- float integer = ceilf(microseconds);
- float difference = integer - microseconds;
+base::TimeDelta ConvertSecondsToTimestamp(double seconds) {
DaleCurtis 2013/04/16 01:19:48 This is a lot simpler written as: const double mi
acolwell GONE FROM CHROMIUM 2013/04/16 16:58:15 Done.
+ double microseconds = seconds * base::Time::kMicrosecondsPerSecond;
+ double integer = ceil(microseconds);
+ double difference = integer - microseconds;
// Round down if difference is large enough.
- if ((microseconds > 0 && difference > 0.5f) ||
- (microseconds <= 0 && difference >= 0.5f)) {
- integer -= 1.0f;
+ if ((microseconds > 0 && difference > 0.5) ||
+ (microseconds <= 0 && difference >= 0.5)) {
+ integer -= 1.0;
}
// Now we can safely cast to int64 microseconds.

Powered by Google App Engine
This is Rietveld 408576698