Pepper: Add VLOG support for NaCl plugins.

base/logging.cc

Index: base/logging.cc
diff --git a/base/logging.cc b/base/logging.cc
index b5e4999ff880eeebe5ee579fd2a79c575c615374..74a024445bd5e709a73af73cd32b487f88c6e722 100644
--- a/base/logging.cc
+++ b/base/logging.cc
@@ -163,6 +163,8 @@ void CloseFile(FileHandle log) {
 void DeleteFilePath(const PathString& log_name) {
 #if defined(OS_WIN)
   DeleteFile(log_name.c_str());
+#elif defined (OS_NACL)
+  // Do nothing; unlink() isn't supported on NaCl.
 #else
   unlink(log_name.c_str());
 #endif
@@ -349,8 +351,6 @@ bool BaseInitLoggingImpl(const PathChar* new_log_file,
                          OldFileDeletionState delete_old,
                          DcheckState dcheck_state) {
   g_dcheck_state = dcheck_state;

[dmichael (off chromium), 2013/04/10 23:10:22]

Is it worth checking that LoggingDestination is either LOG_NONE or
LOG_ONLY_TO_SYSTEM_DEBUG_LOG for NaCl, since the file stuff will crap out later?

-// TODO(bbudge) Hook this up to NaCl logging.
-#if !defined(OS_NACL)
   CommandLine* command_line = CommandLine::ForCurrentProcess();
   // Don't bother initializing g_vlog_info unless we use one of the
   // vlog switches.
@@ -393,10 +393,6 @@ bool BaseInitLoggingImpl(const PathChar* new_log_file,
     DeleteFilePath(*log_file_name);
 
   return InitializeLogFileHandle();
-#else
-  (void) g_vlog_info_prev;
-  return true;
-#endif  // !defined(OS_NACL)
 }
 
 void SetMinLogLevel(int level) {