Pepper: Add VLOG support for NaCl plugins.

chrome/browser/nacl_host/nacl_process_host.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/nacl_host/nacl_process_host.h"
 
 #include <string>
 #include <vector>
 
+#include "base/base_switches.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/path_service.h"
 #include "base/process_util.h"
 #include "base/string_util.h"
 #include "base/stringprintf.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
@@ skipping 21 matching lines @@
 #include "content/public/common/child_process_host.h"
 #include "content/public/common/process_type.h"
 #include "extensions/common/constants.h"
 #include "extensions/common/url_pattern.h"
 #include "ipc/ipc_channel.h"
 #include "ipc/ipc_switches.h"
 #include "native_client/src/shared/imc/nacl_imc_c.h"
 #include "net/base/net_util.h"
 #include "net/base/tcp_listen_socket.h"
 #include "ppapi/proxy/ppapi_messages.h"
+#include "ppapi/shared_impl/ppapi_nacl_channel_args.h"
 
 #if defined(OS_POSIX)
 #include <fcntl.h>
 
 #include "ipc/ipc_channel_posix.h"
 #elif defined(OS_WIN)
 #include <windows.h>
 
 #include "base/process_util.h"
 #include "base/threading/thread.h"
@@ skipping 772 matching lines @@
     // browser process.
     ppapi_host_.reset(content::BrowserPpapiHost::CreateExternalPluginProcess(
         ipc_proxy_channel_.get(),  // sender
         permissions_,
         process_->GetData().handle,
         ipc_proxy_channel_.get(),
         chrome_render_message_filter_->GetHostResolver(),
         chrome_render_message_filter_->render_process_id(),
         render_view_id_));
 
+    ppapi::PpapiNaClChannelArgs args;
+    args.off_the_record = chrome_render_message_filter_->off_the_record();
+    args.permissions = permissions_;
+    CommandLine* cmdline = CommandLine::ForCurrentProcess();
+    DCHECK(cmdline);
+    std::string v_flag = cmdline->GetSwitchValueASCII(switches::kV);

[dmichael (off chromium), 2013/04/10 23:10:22]

Is it worth doing:
std::string flagWhitelist[] = [switches::kV, switches::kVModule];
for (size_t i = 0; i < arraysize(flagWhitelist); ++i) {
  //...
}
?

Feels like we might end up adding more.

+    if (!v_flag.empty()) {
+      args.switch_names.push_back(switches::kV);
+      args.switch_values.push_back(v_flag);
+    }
+    std::string vmodule_flag = cmdline->GetSwitchValueASCII(switches::kVModule);
+    if (!vmodule_flag.empty()) {
+      args.switch_names.push_back(switches::kVModule);
+      args.switch_values.push_back(vmodule_flag);
+    }
+
     // Send a message to create the NaCl-Renderer channel. The handle is just
     // a place holder.
     ipc_proxy_channel_->Send(
         new PpapiMsg_CreateNaClChannel(
             chrome_render_message_filter_->render_process_id(),
-            permissions_,
-            chrome_render_message_filter_->off_the_record(),
+            args,
             SerializedHandle(SerializedHandle::CHANNEL_HANDLE,
                              IPC::InvalidPlatformFileForTransit())));
   } else if (reply_msg_) {
     // Otherwise, this must be a renderer channel.
     ReplyToRenderer(channel_handle);
   } else {
     // Attempt to open more than 1 renderer channel is not supported.
     // Shut down the NaCl process.
     process_->GetHost()->ForceShutdown();
   }
@@ skipping 111 matching lines @@
   } else {
     NaClStartDebugExceptionHandlerThread(
         process_handle.Take(), info,
         base::MessageLoopProxy::current(),
         base::Bind(&NaClProcessHost::OnDebugExceptionHandlerLaunchedByBroker,
                    weak_factory_.GetWeakPtr()));
     return true;
   }
 }
 #endif