chrome/browser/ui/views/frame/browser_view.cc - Issue 13866033: Animate the fullscreen exit bubble's opacity instead of its bounds when in immersive fullscreen

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/frame/browser_view.cc

Issue 13866033: Animate the fullscreen exit bubble's opacity instead of its bounds when in immersive fullscreen (Closed) Base URL: http://git.chromium.org/chromium/src.git@exit_bubble

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/fullscreen/fullscreen_exit_bubble.cc ('K') | « chrome/browser/ui/views/frame/browser_view.h ('k') | chrome/browser/ui/views/fullscreen_exit_bubble_views.h » ('j') | chrome/browser/ui/views/fullscreen_exit_bubble_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/frame/browser_view.cc

diff --git a/chrome/browser/ui/views/frame/browser_view.cc b/chrome/browser/ui/views/frame/browser_view.cc

index 1ad367d85043aa4f499ab4979925be8f57e149c4..4badaa7b849d0ef7999b554e5100241b1a004732 100644

--- a/chrome/browser/ui/views/frame/browser_view.cc

+++ b/chrome/browser/ui/views/frame/browser_view.cc

@@ -863,7 +863,7 @@ void BrowserView::UpdateFullscreenExitBubbleContent(

fullscreen_bubble_->UpdateContent(url, bubble_type);

} else {

fullscreen_bubble_.reset(new FullscreenExitBubbleViews(

- GetWidget(), browser_.get(), url, bubble_type));

+ this, url, bubble_type));

}

@@ -2389,7 +2389,7 @@ void BrowserView::ProcessFullscreen(bool fullscreen,

type != FOR_METRO &&

!UseImmersiveFullscreenForUrl(url)) {

fullscreen_bubble_.reset(new FullscreenExitBubbleViews(

- GetWidget(), browser_.get(), url, bubble_type));

+ this, url, bubble_type));

}

} else {

#if defined(OS_WIN) && !defined(USE_AURA)