Issue 13866011: CrOS: Wait for key press to be processed.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 13866011: CrOS: Wait for key press to be processed. (Closed)

Created:
7 years, 8 months ago by jonathan.backer

Modified:
7 years, 8 months ago

Reviewers:
Daniel Erat

CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org, dmazzoni

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

CrOS: Wait for key press to be processed. --ui-enable-threaded-compositing changes the timing of task processing on the UI thread. It's insufficient to wait for the MessageLoop to go idle --- we must wait for a keypress to be processed. BUG=173417 TEST=interactive_ui_tests --gtest_filter="AshFocusCycleTest*" --ui-enable-threaded-compositing Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=193168

Patch Set 1 #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -3 lines)			Patch
	M	chrome/browser/chromeos/system/ash_focus_cycle_browsertest.cc	View		2 chunks	+16 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/backer@chromium.org/13866011/1

7 years, 8 months ago (2013-04-09 16:48:23 UTC) #3

Message was sent while issue was closed.

Change committed as 193168

Expand Messages | Collapse Messages