Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/closure.dart

Issue 13866010: Correctly compile unresolved for-in loops. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Additional problems found during testing. Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/closure.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/closure.dart b/dart/sdk/lib/_internal/compiler/implementation/closure.dart
index aa17a0079bdad5ed78f786bf586684ab1a367b41..48fa3b3179a952a017a6840514296f8084cb26f4 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/closure.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/closure.dart
@@ -63,6 +63,9 @@ class ClosureTask extends CompilerTask {
}
}
+// TODO(ahe): These classes continuously cause problems. We need to
+// move these classes to elements/modelx.dart or see if we can find a
+// more general solution.
class ClosureFieldElement extends ElementX {
ClosureFieldElement(SourceString name, ClassElement enclosing)
: super(name, ElementKind.FIELD, enclosing);
@@ -79,6 +82,9 @@ class ClosureFieldElement extends ElementX {
String toString() => "ClosureFieldElement($name)";
}
+// TODO(ahe): These classes continuously cause problems. We need to
+// move these classes to elements/modelx.dart or see if we can find a
+// more general solution.
class ClosureClassElement extends ClassElementX {
DartType rawType;
DartType thisType;
@@ -114,11 +120,17 @@ class ClosureClassElement extends ClassElementX {
Element methodElement;
}
+// TODO(ahe): These classes continuously cause problems. We need to
+// move these classes to elements/modelx.dart or see if we can find a
+// more general solution.
class BoxElement extends ElementX {
BoxElement(SourceString name, Element enclosingElement)
: super(name, ElementKind.VARIABLE, enclosingElement);
}
+// TODO(ahe): These classes continuously cause problems. We need to
+// move these classes to elements/modelx.dart or see if we can find a
+// more general solution.
class ThisElement extends ElementX {
ThisElement(Element enclosing)
: super(const SourceString('this'), ElementKind.PARAMETER, enclosing);
@@ -130,6 +142,9 @@ class ThisElement extends ElementX {
Token position() => enclosingElement.position();
}
+// TODO(ahe): These classes continuously cause problems. We need to
+// move these classes to elements/modelx.dart or see if we can find a
+// more general solution.
class CheckVariableElement extends ElementX {
Element parameter;
CheckVariableElement(SourceString name, this.parameter, Element enclosing)

Powered by Google App Engine
This is Rietveld 408576698