Source/WebCore/page/DOMWindow.h - Issue 13866007: WebKit & WebCore part of the device motion implementation using the platform layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/page/DOMWindow.h

Issue 13866007: WebKit & WebCore part of the device motion implementation using the platform layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@devicemotion-webcore

Patch Set: fixed Peter's comments Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/dom/DeviceMotionController.cpp ('K') | « Source/WebCore/history/PageCache.cpp ('k') | Source/WebCore/page/DOMWindow.cpp » ('j') | Source/WebCore/platform/chromium/support/WebDeviceMotionEventPump.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/page/DOMWindow.h

diff --git a/Source/WebCore/page/DOMWindow.h b/Source/WebCore/page/DOMWindow.h

index b316fe67ed7a7a535034ea0605967caed35a7ea1..49cb6e617bf53bbeb279b9890ae5067beb5723c2 100644

--- a/Source/WebCore/page/DOMWindow.h

+++ b/Source/WebCore/page/DOMWindow.h

@@ -410,11 +410,11 @@ namespace WebCore {

void willDetachDocumentFromFrame();

void willDestroyCachedFrame();

- Page* page();

private:

explicit DOMWindow(Document*);

+ Page* page();

Peter Beverloo 2013/04/18 13:56:06 I don't understand why this shows up as a diff? D

timvolodine 2013/04/18 14:55:37 no nothing landed, but this apparently diffs again

virtual void frameDestroyed() OVERRIDE;

virtual void willDetachPage() OVERRIDE;