Source/WebCore/history/PageCache.cpp - Issue 13866007: WebKit & WebCore part of the device motion implementation using the platform layer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/WebCore/history/PageCache.cpp

Issue 13866007: WebKit & WebCore part of the device motion implementation using the platform layer. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@devicemotion-webcore

Patch Set: added unregister in destructor of DeviceMotionController Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/WebCore/dom/DeviceMotionController.cpp ('K') | « Source/WebCore/dom/DeviceMotionController.cpp ('k') | Source/WebCore/page/DOMWindow.h » ('j') | Source/WebCore/platform/PlatformDeviceMotion.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/WebCore/history/PageCache.cpp

diff --git a/Source/WebCore/history/PageCache.cpp b/Source/WebCore/history/PageCache.cpp

index d4b6dc9ed7821330888fd589eab57acde9f5666e..d66750012e6fb4f9a7a4c42095fe3baf64208bab 100644

--- a/Source/WebCore/history/PageCache.cpp

+++ b/Source/WebCore/history/PageCache.cpp

@@ -243,7 +243,7 @@ static void logCanCachePageDecision(Page* page)

rejectReasons |= 1 << DisabledPageCache;

}

#if ENABLE(DEVICE_ORIENTATION)

- if (DeviceMotionController::shared().isActiveAt(page)) {

+ if (DeviceMotionController::isActiveAt(page)) {

PCLOG(" -Page is using DeviceMotion");

rejectReasons |= 1 << UsesDeviceMotion;

}

@@ -388,7 +388,7 @@ bool PageCache::canCache(Page* page) const

&& page->backForward()->isActive()

&& page->settings()->usesPageCache()

#if ENABLE(DEVICE_ORIENTATION)

- && !DeviceMotionController::shared().isActiveAt(page)

+ && !DeviceMotionController::isActiveAt(page)

&& !DeviceOrientationController::isActiveAt(page)

#endif

#if ENABLE(PROXIMITY_EVENTS)