WebKit & WebCore part of the device motion implementation using the platform layer.

Source/WebCore/platform/chromium/support/WebDeviceMotionEventPump.h

+/*
+ * Copyright (C) 2013 Google Inc. All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are
+ * met:
+ *
+ *     * Redistributions of source code must retain the above copyright
+ * notice, this list of conditions and the following disclaimer.
+ *     * Redistributions in binary form must reproduce the above
+ * copyright notice, this list of conditions and the following disclaimer
+ * in the documentation and/or other materials provided with the
+ * distribution.
+ *     * Neither the name of Google Inc. nor the names of its
+ * contributors may be used to endorse or promote products derived from
+ * this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
+ * "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
+ * LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
+ * A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
+ * OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
+ * SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
+ * LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
+ * DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
+ * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
+ * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+#ifndef WebDeviceMotionEventPump_h
+#define WebDeviceMotionEventPump_h
+
+#include "Timer.h"
+#include <DeviceMotionController.h>
+#include <DeviceMotionData.h>
+#include <wtf/CurrentTime.h>
+#include <wtf/HashCountedSet.h>
+#include <wtf/RefCounted.h>
+
+using WebCore::DeviceMotionController;
+using WebCore::DeviceMotionData;
+using WebCore::Timer;

[Peter Beverloo, 2013/04/17 19:08:23]

All three of these forward declares also have #includes. Can we remove the
includes?

[timvolodine, 2013/04/18 12:37:38]

cannot remove the DeviceMotionController.h and DeviceMotionData.h includes
because they are needed for RefPtr. moved <wtf/CurrentTime.h> though.

+
+namespace WebKit {
+
+// FIXME implement a superclass for this, because we will also use
+// a pump for the device orientation events.
+class WebDeviceMotionEventPump {
+public:
+    static const double kPumpDelayMilliSeconds = 100;
+
+    static WebDeviceMotionEventPump& shared();
+
+    void addListener(DeviceMotionController*);
+    void removeListener(DeviceMotionController*);
+
+    // The returned pointer is owned by this class.

[Peter Beverloo, 2013/04/17 19:08:23]

If so, can we make the returned value const?

[timvolodine, 2013/04/18 12:37:38]

I tried doing this, but this change in signature would lead to some significant
refactoring, as the signatures of DeviceMotion.cpp, PlatformDeviceMotion.h,
DeviceMotionEvent.{h,cpp} and possibly others would need to change in multiple
places. Don't think this is worth the trouble, also taking into account that it
is non-const throughout WebCore.

[Peter Beverloo, 2013/04/18 13:56:06]

Can you file a bug on it and add a FIXME? I think it is something we'll want to
address eventually.

[timvolodine, 2013/04/18 14:55:37]

Done.

+    WebCore::DeviceMotionData* latestDeviceMotionData();
+
+private:
+    WebDeviceMotionEventPump(double delay_seconds);
+    ~WebDeviceMotionEventPump() { }
+
+    void start();
+    void stop();
+    void scheduleFireEvent();
+    void fireEvent(Timer<WebDeviceMotionEventPump>*);
+    bool shouldFireEvent();
+
+    double m_delaySeconds;
+    double m_lastFireEventTimeMonotonic;
+    bool m_stopped;
+    WTF::RefPtr<DeviceMotionData> m_lastDeviceMotionData;
+    Timer<WebDeviceMotionEventPump> m_pumpTimer;
+    HashCountedSet<RefPtr<DeviceMotionController> > m_listeners;
+};
+
+} // namespace WebKit
+
+#endif