src/IceTargetLoweringX8632.cpp - Issue 1386593004: Subzero: Fix nondeterministic behavior in constant pool creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceTargetLoweringX8632.cpp

Issue 1386593004: Subzero: Fix nondeterministic behavior in constant pool creation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Update comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceTargetLoweringX8632.cpp

diff --git a/src/IceTargetLoweringX8632.cpp b/src/IceTargetLoweringX8632.cpp

index 9d314acb9c17555709ec61e96fe94d533515a426..efadb85558a0844062e835138c1afc9d4ae6320b 100644

--- a/src/IceTargetLoweringX8632.cpp

+++ b/src/IceTargetLoweringX8632.cpp

@@ -757,7 +757,7 @@ void TargetDataX8632::emitConstantPool(GlobalContext *Ctx) {

assert(CharsPrinted >= 0 &&

(size_t)CharsPrinted < llvm::array_lengthof(buf));

(void)CharsPrinted; // avoid warnings if asserts are disabled

- Const->emitPoolLabel(Str);

+ Const->emitPoolLabel(Str, Ctx);

Str << ":\n\t" << T::AsmTag << "\t" << buf << "\t# " << T::TypeName << " "

<< Value << "\n";

}

« no previous file with comments | « src/IceTargetLoweringARM32.cpp ('k') | src/IceTargetLoweringX8664.cpp » ('j') | no next file with comments »