src/IceFixups.cpp - Issue 1386593004: Subzero: Fix nondeterministic behavior in constant pool creation.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/IceFixups.cpp

Issue 1386593004: Subzero: Fix nondeterministic behavior in constant pool creation. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Patch Set: Update comment Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/IceFixups.cpp

diff --git a/src/IceFixups.cpp b/src/IceFixups.cpp

index a86d985a917b419b6a450a32eab46bb0bfce92ae..6f50f85c61aa0ad3c7b0f78a782896d276b0664e 100644

--- a/src/IceFixups.cpp

+++ b/src/IceFixups.cpp

@@ -43,7 +43,7 @@ IceString AssemblerFixup::symbol(const GlobalContext *Ctx) const {

// NOTE: currently only float/doubles are put into constant pools. In the

// future we may put integers as well.

assert(llvm::isa<ConstantFloat>(C) || llvm::isa<ConstantDouble>(C));

- C->emitPoolLabel(Str);

+ C->emitPoolLabel(Str, Ctx);

}

return Str.str();

}

« no previous file with comments | « src/IceELFObjectWriter.cpp ('k') | src/IceGlobalContext.cpp » ('j') | no next file with comments »