browser test for kAccountsPrefAllowNewUser.

browser test for kAccountsPrefAllowNewUser.

BUG=528265, 539588
TEST=this is the test.

Committed: https://crrev.com/fa4ec1333e7139ce7d4deee4f65edc5a638575d3
Cr-Commit-Position: refs/heads/master@{#352366}

Committed: https://crrev.com/21e6efb80eba96b7c0caf9e717fb794a6a1d75b6
Cr-Commit-Position: refs/heads/master@{#353827}

[achuithb, 2015-10-01 23:34:55]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-01 23:36:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386523002/1

[commit-bot: I haz the power, 2015-10-01 23:59:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-01 23:59:40]

Dry run: This issue passed the CQ dry run.

[achuithb, 2015-10-02 00:03:32]

achuith@chromium.org changed reviewers:
+ bartfab@chromium.org

[achuithb, 2015-10-02 00:03:33]

Bartosz, please take a look.

[achuithb, 2015-10-05 17:25:53]

achuith@chromium.org changed reviewers:
+ jdufault@chromium.org

[achuithb, 2015-10-05 17:25:53]

Jake, could you please review?

[jdufault, 2015-10-05 17:54:14]

lgtm

[achuithb, 2015-10-05 17:55:43]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2015-10-05 17:55:50]

On 2015/10/05 17:54:14, jdufault wrote:
> lgtm

ty

[commit-bot: I haz the power, 2015-10-05 17:57:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386523002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386523002/1

[commit-bot: I haz the power, 2015-10-05 18:47:26]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-10-05 18:48:39]

Patchset 1 (id:??) landed as
https://crrev.com/fa4ec1333e7139ce7d4deee4f65edc5a638575d3
Cr-Commit-Position: refs/heads/master@{#352366}

[maniscalco, 2015-10-05 22:01:12]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1384383002/ by maniscalco@chromium.org.

The reason for reverting is: Suspected as cause of test failure on
chromium.memory.fyi.  For details see
https://code.google.com/p/chromium/issues/detail?id=539588.

[achuithb, 2015-10-08 23:22:58]

Jake, this test got reverted because I landed a proxy check that makes
flow=nosignup the default for all tests (because they can't reach google.com).

Please take another look.

[achuithb, 2015-10-08 23:23:07]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-08 23:23:20]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386523002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386523002/20001

[jdufault, 2015-10-08 23:32:25]

lgtm

https://codereview.chromium.org/1386523002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h (right):

https://codereview.chromium.org/1386523002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h:82: void
DisableRestrictiveProxyCheck();
DisableRestrictiveProxyCheckForTest?

[achuithb, 2015-10-09 01:13:00]

I discovered a low-rate flake in this test, due to the fact that the reload
introduces a second listener as the first one was not removed. I've fixed this -
PTAL.

https://codereview.chromium.org/1386523002/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h (right):

https://codereview.chromium.org/1386523002/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h:82: void
DisableRestrictiveProxyCheck();
On 2015/10/08 23:32:24, jdufault wrote:
> DisableRestrictiveProxyCheckForTest?

Done.

[achuithb, 2015-10-09 01:13:07]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-10-09 01:13:22]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386523002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386523002/60001

[commit-bot: I haz the power, 2015-10-09 01:47:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-10-09 01:47:27]

Dry run: This issue passed the CQ dry run.

[jdufault, 2015-10-09 19:15:40]

lgtm

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/test/oobe_base_test.cc:230: JS()
Can these be on the same line?

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h (right):

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h:283: bool
disable_restrictive_proxy_check_ = false;
Also add the for_test_ postfix here? Up to you.

[achuithb, 2015-10-13 19:20:22]

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/chromeos...
File chrome/browser/chromeos/login/test/oobe_base_test.cc (right):

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/chromeos...
chrome/browser/chromeos/login/test/oobe_base_test.cc:230: JS()
On 2015/10/09 19:15:40, jdufault wrote:
> Can these be on the same line?

git cl format likes it this way and I don't want to fight it.

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h (right):

https://codereview.chromium.org/1386523002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h:283: bool
disable_restrictive_proxy_check_ = false;
On 2015/10/09 19:15:40, jdufault wrote:
> Also add the for_test_ postfix here? Up to you.

Done.

[achuithb, 2015-10-13 19:20:47]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2015-10-13 19:20:48]

The patchset sent to the CQ was uploaded after l-g-t-m from
jdufault@chromium.org
Link to the patchset: https://codereview.chromium.org/1386523002/#ps100001
(title: "disable_restrictive_proxy_check_for_test_")

[commit-bot: I haz the power, 2015-10-13 19:23:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1386523002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1386523002/100001

[commit-bot: I haz the power, 2015-10-13 19:52:54]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2015-10-13 19:53:49]

Patchset 6 (id:??) landed as
https://crrev.com/21e6efb80eba96b7c0caf9e717fb794a6a1d75b6
Cr-Commit-Position: refs/heads/master@{#353827}