Initial design for background compilation

runtime/vm/compiler.h

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #ifndef VM_COMPILER_H_
 #define VM_COMPILER_H_
 
 #include "vm/allocation.h"
 #include "vm/growable_array.h"
 #include "vm/runtime_entry.h"
+#include "vm/thread_pool.h"
 
 namespace dart {
 
 // Forward declarations.
 class Class;
 class Function;
 class Library;
 class ParsedFunction;
 class RawInstance;
 class Script;
@@ skipping 71 matching lines @@
   static bool allow_recompilation() { return allow_recompilation_; }
   static void set_allow_recompilation(bool value) {
     allow_recompilation_ = value;
   }
 
  private:
   static bool always_optimize_;
   static bool allow_recompilation_;
 };
 
+
+class CompileOptimizedTask : public ThreadPool::Task {
+ public:
+  explicit CompileOptimizedTask(Isolate* isolate);
+  ~CompileOptimizedTask();

[koda, 2015/10/01 22:27:02]

I believe this is the first task that defines a destructor. Couldn't you do all
cleanup in Stop, to avoid the split?

Also consider adding 'virtual', for clarity.

[srdjan, 2015/10/01 23:11:24]

Removes destructor, all cleanup in Stop.

+
+  virtual void Run();
+
+  void CompileOptimized(const Function& function);
+
+  void Add(const Function& f);
+  RawFunction* RemoveOrNull();
+
+  Monitor* monitor() const { return monitor_; }
+
+  static void Init(Isolate* isolate);

[koda, 2015/10/01 22:27:02]

What happens if multiple threads call 'Init'? Consider renaming EnsureInit and
use the isolate's mutex.

[srdjan, 2015/10/01 23:11:24]

Done. There is currently only one Dart code thread, but better safe!

+
+  static void Stop(CompileOptimizedTask* task);
+
+ private:
+  Isolate* isolate_;
+  bool running_;
+  bool* done_;
+  Monitor* monitor_;
+  Monitor* done_monitor_;
+
+  DISALLOW_IMPLICIT_CONSTRUCTORS(CompileOptimizedTask);
+};
+
 }  // namespace dart
 
 #endif  // VM_COMPILER_H_