Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(584)

Issue 13865003: Use a sample content settings patterns as placeholder string on the exceptions dialog (Closed)

Created:
7 years, 8 months ago by markusheintz_
Modified:
7 years, 8 months ago
Reviewers:
battre
CC:
chromium-reviews
Visibility:
Public.

Description

On Content Settings exceptions dialogs: Replace the placeholder text ("Add a new hostname pattern") of the input field used for adding new exceptions with a string containing a sample pattern ("[*.]example.com") BUG=232378 TEST= (1) open chrome://settings/contentExceptions#cookies (2) Verify that the text in the input field is "[*.]example.com" Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194592

Patch Set 1 #

Patch Set 2 : Fix typo in the sample pattern #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
markusheintz_
Dominic could you please review this CL ? Thanks a lot
7 years, 8 months ago (2013-04-17 14:22:17 UTC) #1
battre
lgtm
7 years, 8 months ago (2013-04-17 14:27:06 UTC) #2
markusheintz_
7 years, 8 months ago (2013-04-17 15:01:37 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r194592 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698