Source/platform/fonts/win/UniscribeHelper.cpp - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/win/UniscribeHelper.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/win/UniscribeHelper.cpp

diff --git a/Source/platform/fonts/win/UniscribeHelper.cpp b/Source/platform/fonts/win/UniscribeHelper.cpp

index 3b9a3d825294e92101c5b79016805153cf8e47bd..52e471e4f5f7a422494e776ae5a00f8309aed31f 100644

--- a/Source/platform/fonts/win/UniscribeHelper.cpp

+++ b/Source/platform/fonts/win/UniscribeHelper.cpp

@@ -702,7 +702,7 @@ static bool getDerivedFontData(const UChar* family, int style, LOGFONT* logfont,

// check it against what we actually want (as is done in

// FontCacheWin.cpp)

ShaperFontDataCache::AddResult entry = gFontDataCache->add(fontKey, ShaperFontData());

- derived = &entry.iterator->value;

+ derived = &entry.storedValue->value;

derived->hfont = CreateFontIndirect(logfont);

// GetAscent may return kUndefinedAscent, but we still want to

// cache it so that we won't have to call CreateFontIndirect once