Source/platform/fonts/mac/SimpleFontDataCoreText.cpp - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/fonts/mac/SimpleFontDataCoreText.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/platform/fonts/mac/SimpleFontDataCoreText.cpp

diff --git a/Source/platform/fonts/mac/SimpleFontDataCoreText.cpp b/Source/platform/fonts/mac/SimpleFontDataCoreText.cpp

index 80a146e1f4828287b0c11d4c04ca798468479414..a9563507d33b96d912f586dba39bdc4ade2ea95f 100644

--- a/Source/platform/fonts/mac/SimpleFontDataCoreText.cpp

+++ b/Source/platform/fonts/mac/SimpleFontDataCoreText.cpp

@@ -35,7 +35,7 @@ CFDictionaryRef SimpleFontData::getCFStringAttributes(TypesettingFeatures typese

{

unsigned key = typesettingFeatures + 1;

HashMap<unsigned, RetainPtr<CFDictionaryRef> >::AddResult addResult = m_CFStringAttributes.add(key, RetainPtr<CFDictionaryRef>());

- RetainPtr<CFDictionaryRef>& attributesDictionary = addResult.iterator->value;

+ RetainPtr<CFDictionaryRef>& attributesDictionary = addResult.storedValue->value;

if (!addResult.isNewEntry)

return attributesDictionary.get();