Source/core/svg/SVGDocumentExtensions.cpp - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/svg/SVGDocumentExtensions.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/svg/SVGDocumentExtensions.cpp

diff --git a/Source/core/svg/SVGDocumentExtensions.cpp b/Source/core/svg/SVGDocumentExtensions.cpp

index c52c15b62109c5696642a25d020e7f05eebfd56d..c4a5a8f1444ffda93223737b3be9319549e14a60 100644

--- a/Source/core/svg/SVGDocumentExtensions.cpp

+++ b/Source/core/svg/SVGDocumentExtensions.cpp

@@ -153,8 +153,8 @@ void SVGDocumentExtensions::addPendingResource(const AtomicString& id, Element*

HashMap<AtomicString, OwnPtr<SVGPendingElements> >::AddResult result = m_pendingResources.add(id, nullptr);

if (result.isNewEntry)

- result.iterator->value = adoptPtr(new SVGPendingElements);

- result.iterator->value->add(element);

+ result.storedValue->value = adoptPtr(new SVGPendingElements);

+ result.storedValue->value->add(element);

element->setHasPendingResources();

}