Source/core/rendering/shapes/ShapeInfo.h - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/shapes/ShapeInfo.h

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/shapes/ShapeInfo.h

diff --git a/Source/core/rendering/shapes/ShapeInfo.h b/Source/core/rendering/shapes/ShapeInfo.h

index a1ee0606f151caf0efd13c7495fdb574bdb4f7b9..00f9a02836f2176fe6ec05132b8d4b24bd47047c 100644

--- a/Source/core/rendering/shapes/ShapeInfo.h

+++ b/Source/core/rendering/shapes/ShapeInfo.h

@@ -49,7 +49,7 @@ public:

if (InfoType* info = infoMap.get(key))

return info;

typename InfoMap::AddResult result = infoMap.add(key, InfoType::createInfo(key));

- return result.iterator->value.get();

+ return result.storedValue->value.get();

}

static void removeInfo(const KeyType* key) { infoMap().remove(key); }

static InfoType* info(const KeyType* key) { return infoMap().get(key); }