Source/core/html/forms/CheckedRadioButtons.cpp - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/forms/CheckedRadioButtons.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/forms/CheckedRadioButtons.cpp

diff --git a/Source/core/html/forms/CheckedRadioButtons.cpp b/Source/core/html/forms/CheckedRadioButtons.cpp

index b818afa0cdd5e26fcf39059b844c1182a49c6fcd..63005af322f52502cf79e4623ab5ffdcd0ae89bc 100644

--- a/Source/core/html/forms/CheckedRadioButtons.cpp

+++ b/Source/core/html/forms/CheckedRadioButtons.cpp

@@ -193,7 +193,7 @@ void CheckedRadioButtons::addButton(HTMLInputElement* element)

if (!m_nameToGroupMap)

m_nameToGroupMap = adoptPtr(new NameToGroupMap);

- OwnPtr<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name(), PassOwnPtr<RadioButtonGroup>()).iterator->value;

+ OwnPtr<RadioButtonGroup>& group = m_nameToGroupMap->add(element->name(), PassOwnPtr<RadioButtonGroup>()).storedValue->value;

if (!group)

group = RadioButtonGroup::create();

group->add(element);

« no previous file with comments | « Source/core/html/PublicURLManager.cpp ('k') | Source/core/html/forms/FormController.cpp » ('j') | no next file with comments »