Source/core/css/CSSFontFaceSource.cpp - Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSFontFaceSource.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)

Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/css/CSSFontFaceSource.cpp

diff --git a/Source/core/css/CSSFontFaceSource.cpp b/Source/core/css/CSSFontFaceSource.cpp

index a5ce7f92719b93d2553e4a0e0535e5d5e4205cf4..baef101baddb50c914a7a181162743d530b47170 100644

--- a/Source/core/css/CSSFontFaceSource.cpp

+++ b/Source/core/css/CSSFontFaceSource.cpp

@@ -144,7 +144,7 @@ PassRefPtr<SimpleFontData> CSSFontFaceSource::getFontData(const FontDescription&

AtomicString emptyFontFamily = "";

FontCacheKey key = fontDescription.cacheKey(emptyFontFamily);

- RefPtr<SimpleFontData>& fontData = m_fontDataTable.add(key.hash(), 0).iterator->value;

+ RefPtr<SimpleFontData>& fontData = m_fontDataTable.add(key.hash(), 0).storedValue->value;

if (fontData)

return fontData; // No release, because fontData is a reference to a RefPtr that is held in the m_fontDataTable.