Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Side by Side Diff: Source/core/inspector/InspectorTimelineAgent.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)
Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 1173 matching lines...) Expand 10 before | Expand all | Expand 10 after
1184 m_platformInstrumentationClientInstalledAtStackDepth = m_recordStack.siz e(); 1184 m_platformInstrumentationClientInstalledAtStackDepth = m_recordStack.siz e();
1185 PlatformInstrumentation::setClient(this); 1185 PlatformInstrumentation::setClient(this);
1186 } 1186 }
1187 } 1187 }
1188 1188
1189 TimelineThreadState& InspectorTimelineAgent::threadState(ThreadIdentifier thread ) 1189 TimelineThreadState& InspectorTimelineAgent::threadState(ThreadIdentifier thread )
1190 { 1190 {
1191 ThreadStateMap::iterator it = m_threadStates.find(thread); 1191 ThreadStateMap::iterator it = m_threadStates.find(thread);
1192 if (it != m_threadStates.end()) 1192 if (it != m_threadStates.end())
1193 return it->value; 1193 return it->value;
1194 return m_threadStates.add(thread, TimelineThreadState(this)).iterator->value ; 1194 return m_threadStates.add(thread, TimelineThreadState(this)).storedValue->va lue;
1195 } 1195 }
1196 1196
1197 void InspectorTimelineAgent::commitFrameRecord() 1197 void InspectorTimelineAgent::commitFrameRecord()
1198 { 1198 {
1199 if (!m_pendingFrameRecord) 1199 if (!m_pendingFrameRecord)
1200 return; 1200 return;
1201 innerAddRecordToTimeline(m_pendingFrameRecord.release()); 1201 innerAddRecordToTimeline(m_pendingFrameRecord.release());
1202 } 1202 }
1203 1203
1204 void InspectorTimelineAgent::clearRecordStack() 1204 void InspectorTimelineAgent::clearRecordStack()
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
1290 1290
1291 #ifndef NDEBUG 1291 #ifndef NDEBUG
1292 bool TimelineRecordStack::isOpenRecordOfType(const String& type) 1292 bool TimelineRecordStack::isOpenRecordOfType(const String& type)
1293 { 1293 {
1294 return !m_stack.isEmpty() && m_stack.last().type == type; 1294 return !m_stack.isEmpty() && m_stack.last().type == type;
1295 } 1295 }
1296 #endif 1296 #endif
1297 1297
1298 } // namespace WebCore 1298 } // namespace WebCore
1299 1299
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorDebuggerAgent.cpp ('k') | Source/core/inspector/TraceEventDispatcher.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698