Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 138643003: Simpler return value of HashTable::add/HashMap:add and others (Closed)
Patch Set: Daily master update (now with base url?) Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 922 matching lines...) Expand 10 before | Expand all | Expand 10 after
933 return false; 933 return false;
934 934
935 size_t currentNamedGridLine = 0; 935 size_t currentNamedGridLine = 0;
936 for (CSSValueListIterator i = value; i.hasMore(); i.advance()) { 936 for (CSSValueListIterator i = value; i.hasMore(); i.advance()) {
937 CSSValue* currValue = i.value(); 937 CSSValue* currValue = i.value();
938 if (currValue->isGridLineNamesValue()) { 938 if (currValue->isGridLineNamesValue()) {
939 CSSGridLineNamesValue* lineNamesValue = toCSSGridLineNamesValue(curr Value); 939 CSSGridLineNamesValue* lineNamesValue = toCSSGridLineNamesValue(curr Value);
940 for (CSSValueListIterator j = lineNamesValue; j.hasMore(); j.advance ()) { 940 for (CSSValueListIterator j = lineNamesValue; j.hasMore(); j.advance ()) {
941 String namedGridLine = toCSSPrimitiveValue(j.value())->getString Value(); 941 String namedGridLine = toCSSPrimitiveValue(j.value())->getString Value();
942 NamedGridLinesMap::AddResult result = namedGridLines.add(namedGr idLine, Vector<size_t>()); 942 NamedGridLinesMap::AddResult result = namedGridLines.add(namedGr idLine, Vector<size_t>());
943 result.iterator->value.append(currentNamedGridLine); 943 result.storedValue->value.append(currentNamedGridLine);
944 OrderedNamedGridLines::AddResult orderedInsertionResult = ordere dNamedGridLines.add(currentNamedGridLine, Vector<String>()); 944 OrderedNamedGridLines::AddResult orderedInsertionResult = ordere dNamedGridLines.add(currentNamedGridLine, Vector<String>());
945 orderedInsertionResult.iterator->value.append(namedGridLine); 945 orderedInsertionResult.storedValue->value.append(namedGridLine);
946 } 946 }
947 continue; 947 continue;
948 } 948 }
949 949
950 ++currentNamedGridLine; 950 ++currentNamedGridLine;
951 trackSizes.append(createGridTrackSize(currValue, state)); 951 trackSizes.append(createGridTrackSize(currValue, state));
952 } 952 }
953 953
954 // The parser should have rejected any <track-list> without any <track-size> as 954 // The parser should have rejected any <track-list> without any <track-size> as
955 // this is not conformant to the syntax. 955 // this is not conformant to the syntax.
(...skipping 1183 matching lines...) Expand 10 before | Expand all | Expand 10 after
2139 break; 2139 break;
2140 } 2140 }
2141 case CSSPropertyEnableBackground: 2141 case CSSPropertyEnableBackground:
2142 // Silently ignoring this property for now 2142 // Silently ignoring this property for now
2143 // http://bugs.webkit.org/show_bug.cgi?id=6022 2143 // http://bugs.webkit.org/show_bug.cgi?id=6022
2144 break; 2144 break;
2145 } 2145 }
2146 } 2146 }
2147 2147
2148 } // namespace WebCore 2148 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/css/resolver/ScopedStyleTree.cpp ('k') | Source/core/dom/ChildListMutationScope.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698