Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 138643002: [Telemetry] Make record_wpr call test.WillNavigateToPage and test.DidNavigateToPage. (Closed)

Created:
6 years, 11 months ago by slamm
Modified:
6 years, 11 months ago
Reviewers:
tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Make record_wpr call test.WillNavigateToPage and test.DidNavigateToPage. BUG=331607 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245333

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/telemetry/telemetry/page/record_wpr.py View 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
slamm
I needed these changes to record my new measurement. I am unsure if there would ...
6 years, 11 months ago (2014-01-14 23:29:26 UTC) #1
tonyg
lgtm
6 years, 11 months ago (2014-01-15 00:46:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/138643002/1
6 years, 11 months ago (2014-01-16 14:37:27 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-16 19:36:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/slamm@chromium.org/138643002/1
6 years, 11 months ago (2014-01-16 19:57:09 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 21:38:45 UTC) #6
Message was sent while issue was closed.
Change committed as 245333

Powered by Google App Engine
This is Rietveld 408576698