third_party/WebKit/Source/core/style/StyleGeneratedImage.h - Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

Issue 1386413002: Added TODOs to StyleImage::create() to take PassRefPtrWillBeRawPtr (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@make_styleresolverstate_styleImage_take_a_const_reference

Patch Set: Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/style/StyleGeneratedImage.h

diff --git a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

index 4703939642e1ca18d91cbf3258a3574472b22265..68ccd511a3b2e4168c30bfee51686fe3871aaa28 100644

--- a/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

+++ b/third_party/WebKit/Source/core/style/StyleGeneratedImage.h

@@ -34,6 +34,7 @@ class CSSImageGeneratorValue;

class CORE_EXPORT StyleGeneratedImage final : public StyleImage {

public:

+ // TODO(sashab): Make this take a PassRefPtrWillBeRawPtr<const CSSImageGeneratorValue>.

alancutter (OOO until 2018) 2015/10/07 04:38:05 In the meantime we can make these PassRefPtrWillBe

static PassRefPtrWillBeRawPtr<StyleGeneratedImage> create(const CSSImageGeneratorValue& value)

{

return adoptRefWillBeNoop(new StyleGeneratedImage(value));

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/style/StylePendingImage.h » ('j') | no next file with comments »