Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4391)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Issue 1386403003: Resize only the virtual viewport when the OSK triggers a resize. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add inset consumer view one off the root view Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index f5555ba00fde36175d9809637a8d88ab294a6536..41f0fc536a879a6f7e6320e4bb672a4dd92edee4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -431,6 +431,42 @@ public final class Tab implements ViewGroup.OnHierarchyChangeListener,
}
@Override
+ public int getSystemWindowInsetLeft() {
Ted C 2016/03/12 00:01:44 instead of having 4 methods, I wonder if we should
+ ChromeActivity activity = getActivity();
+ if (activity != null && activity.getInsetConsumerView() != null) {
Ted C 2016/03/12 00:01:44 As far as I can tell from your patch, the inset co
+ return activity.getInsetConsumerView().getSystemWindowInsetsLeft();
+ }
+ return 0;
+ }
+
+ @Override
+ public int getSystemWindowInsetTop() {
+ ChromeActivity activity = getActivity();
+ if (activity != null && activity.getInsetConsumerView() != null) {
+ return activity.getInsetConsumerView().getSystemWindowInsetsTop();
+ }
+ return 0;
+ }
+
+ @Override
+ public int getSystemWindowInsetRight() {
+ ChromeActivity activity = getActivity();
+ if (activity != null && activity.getInsetConsumerView() != null) {
+ return activity.getInsetConsumerView().getSystemWindowInsetsRight();
+ }
+ return 0;
+ }
+
+ @Override
+ public int getSystemWindowInsetBottom() {
+ ChromeActivity activity = getActivity();
+ if (activity != null && activity.getInsetConsumerView() != null) {
+ return activity.getInsetConsumerView().getSystemWindowInsetsBottom();
+ }
+ return 0;
+ }
+
+ @Override
public ContentVideoViewEmbedder getContentVideoViewEmbedder() {
return new ActivityContentVideoViewEmbedder(getActivity()) {
@Override

Powered by Google App Engine
This is Rietveld 408576698