Resize only the virtual viewport when the OSK triggers a resize.

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 17 matching lines @@
 import android.util.Pair;
 import android.util.TypedValue;
 import android.view.ActionMode;
 import android.view.HapticFeedbackConstants;
 import android.view.InputDevice;
 import android.view.KeyEvent;
 import android.view.MotionEvent;
 import android.view.View;
 import android.view.ViewGroup;
 import android.view.ViewStructure;
+import android.view.WindowInsets;
 import android.view.accessibility.AccessibilityManager;
 import android.view.accessibility.AccessibilityManager.AccessibilityStateChangeListener;
 import android.view.accessibility.AccessibilityNodeProvider;
 import android.view.inputmethod.EditorInfo;
 import android.view.inputmethod.InputConnection;
 import android.view.inputmethod.InputMethodManager;
 import android.widget.FrameLayout;
 
 import org.chromium.base.ApiCompatibilityUtils;
 import org.chromium.base.CommandLine;
@@ skipping 415 matching lines @@
     private PastePopupMenu mPastePopupMenu;
     private boolean mWasPastePopupShowingOnInsertionDragStart;
 
     // Size of the viewport in physical pixels as set from onSizeChanged.
     private int mViewportWidthPix;
     private int mViewportHeightPix;
     private int mPhysicalBackingWidthPix;
     private int mPhysicalBackingHeightPix;
     private int mTopControlsHeightPix;
     private boolean mTopControlsShrinkBlinkSize;
+    private Rect mWindowInsets;

[aelias_OOO_until_Jul13, 2016/01/28 05:04:55]

Please add code that will guarantee this is populated correctly on a newly
created ContentViewCore.

[ymalik, 2016/02/11 01:06:22]

Done.

 
     // Cached copy of all positions and scales as reported by the renderer.
     private final RenderCoordinates mRenderCoordinates;
 
     // Provides smooth gamepad joystick-driven scrolling.
     private final JoystickScrollProvider mJoystickScrollProvider;
 
     private boolean mIsMobileOptimizedHint;
 
     // Tracks whether a selection is currently active.  When applied to selected text, indicates
@@ skipping 135 matching lines @@
     }
 
     /**
      * @return The ViewGroup that all view actions of this ContentViewCore should interact with.
      */
     public ViewGroup getContainerView() {
         return mContainerView;
     }
 
     /**
+     * @return The system window insets (from OSK, status bar, etc).
+     */
+    public Rect getWindowInsets() {
+        return mWindowInsets != null ? mWindowInsets : new Rect();
+    }
+
+    /**
+     * @param insets The system window insets Rect (from OSK, status bar, etc).
+     */
+    public void setWindowInsets(Rect insets) {
+        mWindowInsets = insets;
+    }
+
+    /**
+     * @param insets The insets (from OSK, status bar, etc).
+     */
+    @TargetApi(Build.VERSION_CODES.LOLLIPOP)
+    public void setWindowInsets(WindowInsets insets) {

[AKV, 2016/02/10 11:35:28]

private

[ymalik, 2016/02/11 01:06:23]

The setWindowInsets function is used by InsetConsumerView and can not be
private.

+        if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) return;

[AKV, 2016/02/10 11:35:28]

if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP || insets == null)
return;

[ymalik, 2016/02/11 01:06:22]

Removed this function.

+        if (insets == null) return;
+        mWindowInsets = new Rect(insets.getSystemWindowInsetLeft(),

[aelias_OOO_until_Jul13, 2016/01/28 05:04:55]

Could you create this once at construction time and use Rect.set() instead? 
(Constructing objects is something we avoid in Java when feasible due to GC
pauses.)

[ymalik, 2016/02/11 01:06:22]

I have removed this function and changed it to take the L T R B params. See
comment in InsetViewConsumer.

+                insets.getSystemWindowInsetTop(),
+                insets.getSystemWindowInsetRight(),
+                insets.getSystemWindowInsetBottom());
+    }
+
+    /**
      * @return The WebContents currently being rendered.
      */
     public WebContents getWebContents() {
         return mWebContents;
     }
 
     /**
      * @return The WindowAndroid associated with this ContentViewCore.
      */
     public WindowAndroid getWindowAndroid() {
@@ skipping 378 matching lines @@
 
     /**
      * @return Viewport height in physical pixels as set from onSizeChanged.
      */
     @CalledByNative
     public int getViewportHeightPix() {
         return mViewportHeightPix;
     }
 
     /**
+     * @return Viewport height when the OSK is hidden in physical pixels as set from onSizeChanged.
+     */
+    @CalledByNative
+    public int getViewportHeightWithOSKHiddenPix() {
+        return mViewportHeightPix + getWindowInsets().bottom;

[aelias_OOO_until_Jul13, 2016/01/28 05:04:55]

Your design doc says this includes the status bar, should there be code
correcting for that?

[bokan, 2016/01/28 15:53:42]

The status bar would presumably be in getWindowInsets().top. But the problem
stands for the "button bar" (Action Bar?), that should be included in bottom
here. Is there a way to differentiate between the action bar and the OSK?

[ymalik, 2016/02/11 01:06:22]

That's right. The status bar is in getWindowInsets().bottom.

The navigation bar is actually not a part of WindowInsets.bottom from where we
consume it. The navigation bar will only be included in the insets if an
application sets to draw behind the nav buttons (using
SYSTEM_UI_FLAG_LAYOUT_FULLSCREEN, etc). 
https://developer.android.com/reference/android/view/View.html#SYSTEM_UI_FLAG...

Clank does set this flag when in fullscreen mode, but in that case, we actually
do want to include the navigation bar in the insetso this works well. 

+    }
+
+    /**
      * @return Width of underlying physical surface.
      */
     @CalledByNative
     private int getPhysicalBackingWidthPix() {
         return mPhysicalBackingWidthPix;
     }
 
     /**
      * @return Height of underlying physical surface.
      */
@@ skipping 2257 matching lines @@
     private native void nativeSetTextTrackSettings(long nativeContentViewCoreImpl,
             boolean textTracksEnabled, String textTrackBackgroundColor, String textTrackFontFamily,
             String textTrackFontStyle, String textTrackFontVariant, String textTrackTextColor,
             String textTrackTextShadow, String textTrackTextSize);
 
     private native void nativeExtractSmartClipData(long nativeContentViewCoreImpl,
             int x, int y, int w, int h);
 
     private native void nativeSetBackgroundOpaque(long nativeContentViewCoreImpl, boolean opaque);
 }