Resize only the virtual viewport when the OSK triggers a resize.

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 186 matching lines @@
     // We have to instantiate the TouchExplorationStateChangeListner object in the code.
     @SuppressLint("NewApi")
     private TouchExplorationStateChangeListener mTouchExplorationStateChangeListener;
 
     // Observes when sync becomes ready to create the mContextReporter.
     private ProfileSyncService.SyncStateChangedListener mSyncStateChangedListener;
 
     private ActivityWindowAndroid mWindowAndroid;
     private ChromeFullscreenManager mFullscreenManager;
     private CompositorViewHolder mCompositorViewHolder;
+    private InsetConsumerView mInsetConsumerView;
     private ContextualSearchManager mContextualSearchManager;
     private ReaderModeManager mReaderModeManager;
     private SnackbarManager mSnackbarManager;
     private DataUseSnackbarController mDataUseSnackbarController;
     private AppMenuPropertiesDelegate mAppMenuPropertiesDelegate;
     private AppMenuHandler mAppMenuHandler;
     private ToolbarManager mToolbarManager;
     private BookmarkModelObserver mBookmarkObserver;
 
     // Time in ms that it took took us to inflate the initial layout
@@ skipping 119 matching lines @@
         TraceEvent.end("onCreate->setContentView()");
         mInflateInitialLayoutDurationMs = SystemClock.elapsedRealtime() - begin;
 
         // Set the status bar color to black by default. This is an optimization for
         // Chrome not to draw under status and navigation bars when we use the default
         // black status bar
         ApiCompatibilityUtils.setStatusBarColor(getWindow(), Color.BLACK);
 
         mCompositorViewHolder = (CompositorViewHolder) findViewById(R.id.compositor_view_holder);
         mCompositorViewHolder.setRootView(getWindow().getDecorView().getRootView());
+
+        // Setting fitsSystemWindows to false ensures that the parent views in
+        // the View hierarchy don't consume the insets. ContentViewCore needs
+        // the insets to determine the portion of the screen obscured by
+        // non-content displaying things such as the OSK.
+        View parent = mCompositorViewHolder;
+        while (parent.getParent() != null && parent.getParent() instanceof View) {

[aelias_OOO_until_Jul13, 2016/01/28 05:04:55]

This can be simplified to:

for (View parent = mCompositorViewHolder; parent instanceof View; parent =
parent.getParent()) {
  parent.setFitsSystemWindows(false);
}

[ymalik, 2016/02/11 01:06:22]

We don't check here if the actual parent of the view is an instance of View.
Instead, we check if the View is an instance of View which is always true.

[aelias_OOO_until_Jul13, 2016/02/24 02:43:58]

OK, I stand corrected.  Anyway, at least please delete "parent.getParent() !=
null" check because that's already considered by instanceof.

[ymalik, 2016/03/03 02:10:17]

Done.

+            parent = (View) parent.getParent();
+            parent.setFitsSystemWindows(false);
+        }
+        // InsetConsumerView consumes the insets instead, so that the actual
+        // value of the insets can be stored.
+        mInsetConsumerView = (InsetConsumerView) findViewById(R.id.inset_consumer_view);
+        if (mInsetConsumerView != null) {
+            mInsetConsumerView.setFitsSystemWindows(true);

[aelias_OOO_until_Jul13, 2016/01/28 05:04:55]

The Android docs on this method says "Note that if you are providing your own
implementation of fitSystemWindows(Rect), then there is no need to set this flag
to true -- your implementation will be overriding the default implementation
that checks this flag."

[bokan, 2016/01/28 15:53:41]

I think you need to set it since the override of fitSystemWindows calls the
super method.

[aelias_OOO_until_Jul13, 2016/02/24 02:43:58]

How about simply not calling super.fitSystemWindows in our override then, like
the Android docs suggest?

[ymalik, 2016/03/03 02:10:17]

super.fitSystemWindows is what actually applies the insets. The override in
InsetConsumerView just stores it, so we need to call it.

+            mInsetConsumerView.setTabModelSelector(getTabModelSelector());
+        }
     }
 
     /**
      * Constructs {@link ToolbarManager} and the handler necessary for controlling the menu on the
      * {@link Toolbar}. Extending classes can override this call to avoid creating the toolbar.
      */
     protected void initializeToolbar() {
         final View controlContainer = findViewById(R.id.control_container);
         assert controlContainer != null;
         ToolbarControlContainer toolbarContainer = (ToolbarControlContainer) controlContainer;
@@ skipping 159 matching lines @@
 
                 ControlContainer controlContainer =
                         (ControlContainer) findViewById(R.id.control_container);
                 controlContainer.getToolbarResourceAdapter().invalidate(null);
             }
         };
 
         if (mAssistStatusHandler != null) {
             mAssistStatusHandler.setTabModelSelector(tabModelSelector);
         }
+
+        if (mInsetConsumerView != null) {
+            mInsetConsumerView.setTabModelSelector(tabModelSelector);
+        }
     }
 
     @Override
     public void onStartWithNative() {
         super.onStartWithNative();
         UpdateMenuItemHelper.getInstance().onStart();
         getChromeApplication().onStartWithNative();
         FeatureUtilities.setDocumentModeEnabled(FeatureUtilities.isDocumentMode(this));
         WarmupManager.getInstance().clearWebContentsIfNecessary();
 
@@ skipping 1052 matching lines @@
     public static int getThemeId() {
         boolean useLowEndTheme =
                 SysUtils.isLowEndDevice() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
         return (useLowEndTheme ? R.style.MainTheme_LowEnd : R.style.MainTheme);
     }
 
     private void setLowEndTheme() {
         if (getThemeId() == R.style.MainTheme_LowEnd) setTheme(R.style.MainTheme_LowEnd);
     }
 }