Resize only the virtual viewport when the OSK triggers a resize.

chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.annotation.SuppressLint;
 import android.annotation.TargetApi;
 import android.app.Activity;
 import android.app.SearchManager;
@@ skipping 187 matching lines @@
     // We have to instantiate the TouchExplorationStateChangeListner object in the code.
     @SuppressLint("NewApi")
     private TouchExplorationStateChangeListener mTouchExplorationStateChangeListener;
 
     // Observes when sync becomes ready to create the mContextReporter.
     private ProfileSyncService.SyncStateChangedListener mSyncStateChangedListener;
 
     private ActivityWindowAndroid mWindowAndroid;
     private ChromeFullscreenManager mFullscreenManager;
     private CompositorViewHolder mCompositorViewHolder;
+    private InsetConsumerView mInsetConsumerView;
     private ContextualSearchManager mContextualSearchManager;
     private ReaderModeManager mReaderModeManager;
     private SnackbarManager mSnackbarManager;
     private DataUseSnackbarController mDataUseSnackbarController;
     private AppMenuPropertiesDelegate mAppMenuPropertiesDelegate;
     private AppMenuHandler mAppMenuHandler;
     private ToolbarManager mToolbarManager;
     private BookmarkModelObserver mBookmarkObserver;
 
     // Time in ms that it took took us to inflate the initial layout
@@ skipping 129 matching lines @@
         TraceEvent.end("onCreate->setContentView()");
         mInflateInitialLayoutDurationMs = SystemClock.elapsedRealtime() - begin;
 
         // Set the status bar color to black by default. This is an optimization for
         // Chrome not to draw under status and navigation bars when we use the default
         // black status bar
         ApiCompatibilityUtils.setStatusBarColor(getWindow(), Color.BLACK);
 
         mCompositorViewHolder = (CompositorViewHolder) findViewById(R.id.compositor_view_holder);
         mCompositorViewHolder.setRootView(getWindow().getDecorView().getRootView());
+
+        // Add a custom view right after the root view that consumes the insets
+        // and stores it to access later. ContentViewCore needs the insets to
+        // determine the portion of the screen obscured by non-content

[Ted C, 2016/03/12 00:01:43]

I don't really like mucking with the view hierarchy if we can avoid it.  I
played around with this a bit and you can just do:

mInsetConsumerView = new InsetConsumerView(this);
rootView.addView(mInsetConsumerView, 0);

It needs to be at position 0 because of how insets are consumed.  The first
child of a view that states it has consumed the insets wins.  By adding
ourselves first, we can see them but signal we don't use them.

This does have some implications, but I will mention those in the
InsetConsumerView class.  I think this is much nicer though.

[ymalik, 2016/03/14 22:19:01]

Done.

+        // displaying things such as the OSK.
+        ViewGroup rootView = (ViewGroup) getWindow().getDecorView().getRootView();

[Ted C, 2016/03/12 00:01:43]

this is also needed above in setRootView, so let's pull it out as a shared var.

[ymalik, 2016/03/14 22:19:01]

Done.

+        // Setting fitsSystemWindows to false ensures that the root view
+        // doesn't consume the insets.
+        rootView.setFitsSystemWindows(false);

[Ted C, 2016/03/12 00:01:43]

this didn't seem necessary in my prototyping

[ymalik, 2016/03/14 22:19:01]

I had this in case the compat lib was ever changed and the root view did
actually consume the insets. I can get rid of this if this is not a legitimate
concern. WDYT?

+        // Transfer child view hierarchy to InsetConsumerView. This is needed to
+        // ensure that the insets are applied properly.
+        InsetConsumerView insetConsumerView = new InsetConsumerView(this);
+        insetConsumerView.setFitsSystemWindows(true);

[Ted C, 2016/03/12 00:01:44]

move this to the constructor

[ymalik, 2016/03/14 22:19:01]

I don't think we need this with the sibling approach (since we're not actually
consuming the insets)

+        while (rootView.getChildCount() > 0) {
+            View currentChild = rootView.getChildAt(0);
+            rootView.removeView(currentChild);
+            insetConsumerView.addView(currentChild);
+        }
+        rootView.addView(insetConsumerView);
+        mInsetConsumerView = insetConsumerView;
     }
 
     /**
      * Constructs {@link ToolbarManager} and the handler necessary for controlling the menu on the
      * {@link Toolbar}. Extending classes can override this call to avoid creating the toolbar.
      */
     protected void initializeToolbar() {
         final View controlContainer = findViewById(R.id.control_container);
         assert controlContainer != null;
         ToolbarControlContainer toolbarContainer = (ToolbarControlContainer) controlContainer;
@@ skipping 685 matching lines @@
 
     /**
      * {@link TabModelSelector} no longer implements TabModel.  Use getTabModelSelector() or
      * getCurrentTabModel() depending on your needs.
      * @return The {@link TabModelSelector}, possibly null.
      */
     public TabModelSelector getTabModelSelector() {
         return mTabModelSelector;
     }
 
+    /**
+     * Returns the {@link InsetConsumerView} that has the current system window
+     * insets information.
+     * @return The {@link InsetConsumerView}, possibly null.
+     */
+    public InsetConsumerView getInsetConsumerView() {
+        return mInsetConsumerView;
+    }
+
     @Override
     public TabCreatorManager.TabCreator getTabCreator(boolean incognito) {
         return incognito ? mIncognitoTabCreator : mRegularTabCreator;
     }
 
     /**
      * Sets the {@link ChromeTabCreator}s owned by this {@link ChromeActivity}.
      * @param regularTabCreator A {@link ChromeTabCreator} instance.
      */
     public void setTabCreators(TabCreatorManager.TabCreator regularTabCreator,
@@ skipping 536 matching lines @@
     public static int getThemeId() {
         boolean useLowEndTheme =
                 SysUtils.isLowEndDevice() && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP;
         return (useLowEndTheme ? R.style.MainTheme_LowEnd : R.style.MainTheme);
     }
 
     private void setLowEndTheme() {
         if (getThemeId() == R.style.MainTheme_LowEnd) setTheme(R.style.MainTheme_LowEnd);
     }
 }