Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6445)

Unified Diff: chrome/browser/ui/views/create_application_shortcut_view.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: rework Created 7 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index 7c070eb331b0dbd4447e36501cf0fc0e2afb52ad..c3969caa88e1808bcfe0c9b6fc63ee845850cffb 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -371,9 +371,12 @@ bool CreateApplicationShortcutView::Accept() {
ShellIntegration::ShortcutLocations creation_locations;
creation_locations.on_desktop = desktop_check_box_->checked();
- creation_locations.in_applications_menu = menu_check_box_ == NULL ? false :
- menu_check_box_->checked();
- creation_locations.applications_menu_subdir = shortcut_menu_subdir_;
+ if (menu_check_box_ != NULL && menu_check_box_->checked()) {
+ if (create_in_chrome_apps_subdir_)
+ creation_locations.in_applications_menu_chrome_apps_subdir = true;
+ else
+ creation_locations.in_applications_menu_root = true;
+ }
#if defined(OS_WIN)
creation_locations.in_quick_launch_bar = quick_launch_check_box_ == NULL ?
@@ -430,8 +433,8 @@ CreateUrlApplicationShortcutView::CreateUrlApplicationShortcutView(
FetchIcon();
}
- // NOTE: Leave shortcut_menu_subdir_ blank to create URL app shortcuts in the
- // top-level menu.
+ // Create URL app shortcuts in the top-level menu.
+ create_in_chrome_apps_subdir_ = false;
InitControls();
}
@@ -518,7 +521,7 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView(
shortcut_info_.description = UTF8ToUTF16(app->description());
// Place Chrome app shortcuts in the "Chrome Apps" submenu.
- shortcut_menu_subdir_ = web_app::GetAppShortcutsSubdirName();
+ create_in_chrome_apps_subdir_ = true;
InitControls();

Powered by Google App Engine
This is Rietveld 408576698