chrome/browser/shell_integration_win_unittest.cc - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration_win_unittest.cc

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: rework Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/shell_integration_win.cc ('K') | « chrome/browser/shell_integration_win.cc ('k') | chrome/browser/ui/views/app_list/app_list_controller_win.cc » ('j') | chrome/browser/ui/views/app_list/app_list_controller_win.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/shell_integration_win_unittest.cc

diff --git a/chrome/browser/shell_integration_win_unittest.cc b/chrome/browser/shell_integration_win_unittest.cc

index b27d557c853cea1e9002b08c7b4e53f808c0009e..e50a4aa4b24758719cd59acd770e66f1a159778d 100644

--- a/chrome/browser/shell_integration_win_unittest.cc

+++ b/chrome/browser/shell_integration_win_unittest.cc

@@ -335,6 +335,9 @@ TEST(ShellIntegrationWinTest, GetAppModelIdForProfileTest) {

TEST(ShellIntegrationWinTest, GetAppListAppModelIdForProfileTest) {

string16 base_app_id(BrowserDistribution::GetDistribution()->GetBaseAppId());

base_app_id.append(L"AppList");

+ string16 suffix;

+ ShellUtil::GetUserSpecificRegistrySuffix(&suffix);

+ base_app_id.append(suffix);

gab 2013/04/29 21:34:44 You can remove this code.

calamity 2013/04/30 08:11:28 Done.

// Empty profile path should get chrome::kBrowserAppID + AppList

base::FilePath empty_path;