Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4309)

Unified Diff: chrome/installer/util/shell_util.h

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix
Patch Set: rebase, move app launcher and chrome app strings into the installer Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/shell_util.h
diff --git a/chrome/installer/util/shell_util.h b/chrome/installer/util/shell_util.h
index 5977023f832ab7d1276caabae872d61d662614a4..880a9ba85cff2a306aa76b6caf70f53176b581e9 100644
--- a/chrome/installer/util/shell_util.h
+++ b/chrome/installer/util/shell_util.h
@@ -44,7 +44,9 @@ class ShellUtil {
enum ShortcutLocation {
SHORTCUT_LOCATION_DESKTOP,
SHORTCUT_LOCATION_QUICK_LAUNCH,
- SHORTCUT_LOCATION_START_MENU,
+ SHORTCUT_LOCATION_START_MENU_ROOT,
+ SHORTCUT_LOCATION_START_MENU_CHROME_DIR,
+ SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR,
SHORTCUT_LOCATION_TASKBAR_PINS, // base::win::VERSION_WIN7 +
SHORTCUT_LOCATION_APP_SHORTCUTS, // base::win::VERSION_WIN8 +
};
@@ -321,7 +323,9 @@ class ShellUtil {
// |properties| and |operation| affect this method as described on their
// invidividual definitions above.
// |location| may be one of SHORTCUT_LOCATION_DESKTOP,
- // SHORTCUT_LOCATION_QUICK_LAUNCH, or SHORTCUT_LOCATION_START_MENU.
+ // SHORTCUT_LOCATION_QUICK_LAUNCH, SHORTCUT_LOCATION_START_MENU_ROOT,
+ // SHORTCUT_LOCATION_START_MENU_CHROME_DIR or
huangs 2013/05/15 02:33:46 Add "," back; I think Oxford comma improves readab
gab 2013/05/15 21:26:38 +1
calamity 2013/08/27 07:59:35 Done.
+ // SHORTCUT_LOCATION_START_MENU_CHROME_APPS_DIR.
static bool CreateOrUpdateShortcut(
ShellUtil::ShortcutLocation location,
BrowserDistribution* dist,
@@ -536,6 +540,7 @@ class ShellUtil {
const base::FilePath& target_exe,
const ShellUtil::ShortcutProperties& properties);
+
huangs 2013/05/15 02:33:46 Delete extra line.
calamity 2013/08/27 07:59:35 Done.
// Sets |suffix| to the base 32 encoding of the md5 hash of this user's sid
// preceded by a dot.
// This is guaranteed to be unique on the machine and 27 characters long

Powered by Google App Engine
This is Rietveld 408576698