Move app launcher and chrome apps shortcut strings into the installer

chrome/browser/ui/views/create_application_shortcut_view.cc

Index: chrome/browser/ui/views/create_application_shortcut_view.cc
diff --git a/chrome/browser/ui/views/create_application_shortcut_view.cc b/chrome/browser/ui/views/create_application_shortcut_view.cc
index 3f4feb8ca092f0116b7f1e33ccc4f668a9c3edbe..908371551edd4c4ca6ab164b9960b85b59264f65 100644
--- a/chrome/browser/ui/views/create_application_shortcut_view.cc
+++ b/chrome/browser/ui/views/create_application_shortcut_view.cc
@@ -376,10 +376,12 @@ bool CreateApplicationShortcutView::Accept() {
 
   ShellIntegration::ShortcutLocations creation_locations;
   creation_locations.on_desktop = desktop_check_box_->checked();
-  creation_locations.in_applications_menu = menu_check_box_ == NULL ? false :
-      menu_check_box_->checked();
-  creation_locations.applications_menu_subdir = shortcut_menu_subdir_;
-
+  if (menu_check_box_ != NULL && menu_check_box_->checked()) {

[Matt Giuca, 2013/05/15 05:19:45]

You will need to make this change in
chrome/browser/ui/gtk/create_application_shortcuts_dialog_gtk.(h|cc). This is
only compiled on Linux (hence you didn't notice it on Windows).

+    if (create_in_chrome_apps_subdir_)
+      creation_locations.in_applications_menu_chrome_apps_subdir = true;
+    else
+      creation_locations.in_applications_menu = true;
+  }
 #if defined(OS_WIN)
   creation_locations.in_quick_launch_bar = quick_launch_check_box_ == NULL ?
       NULL : quick_launch_check_box_->checked();
@@ -433,8 +435,8 @@ CreateUrlApplicationShortcutView::CreateUrlApplicationShortcutView(
     FetchIcon();
   }
 
-  // NOTE: Leave shortcut_menu_subdir_ blank to create URL app shortcuts in the
-  // top-level menu.
+  // Create URL app shortcuts in the top-level menu.
+  create_in_chrome_apps_subdir_ = false;

[Matt Giuca, 2013/05/15 05:19:45]

I'm glad this comment came in handy :)

 
   InitControls();
 }
@@ -516,7 +518,7 @@ CreateChromeApplicationShortcutView::CreateChromeApplicationShortcutView(
   shortcut_info_.description = UTF8ToUTF16(app->description());
 
   // Place Chrome app shortcuts in the "Chrome Apps" submenu.
-  shortcut_menu_subdir_ = web_app::GetAppShortcutsSubdirName();
+  create_in_chrome_apps_subdir_ = true;
 
   InitControls();