chrome/browser/shell_integration.h - Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/shell_integration.h

Issue 13864015: Move app launcher and chrome apps shortcut strings into the installer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@migrate_app_id_fix

Patch Set: rebase, move app launcher and chrome app strings into the installer Created 7 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/shell_integration.h

diff --git a/chrome/browser/shell_integration.h b/chrome/browser/shell_integration.h

index 1306027b3e993a20b6f61795f517ff2c9c7383f2..ae5c8fe1cf431e1af55cb213b9a24c21203af741 100644

--- a/chrome/browser/shell_integration.h

+++ b/chrome/browser/shell_integration.h

@@ -110,8 +110,12 @@ class ShellIntegration {

ShortcutLocations();

bool on_desktop;

+ // For Windows, these refer to Start Menu/, Start Menu/Google Chrome, and

+ // Start Menu/Chrome Apps respectively.

Matt Giuca 2013/05/15 05:19:45 Put quotes around these for readability like "Star

calamity 2013/08/27 07:59:35 Done.

bool in_applications_menu;

huangs 2013/05/15 02:33:46 in_application_menu_root

calamity 2013/08/27 07:59:35 Done.

- string16 applications_menu_subdir;

+ bool in_applications_menu_chrome_subdir;

+ bool in_applications_menu_chrome_apps_subdir;

// For Windows, this refers to quick launch bar prior to Win7. In Win7,

// this means "pin to taskbar". For Mac/Linux, this could be used for

« no previous file with comments | « chrome/browser/chrome_browser_main_win.cc ('k') | chrome/browser/shell_integration.cc » ('j') | chrome/browser/shell_integration.cc » ('J')